fix: compound tasks run all tasks #379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
added a commit
that referenced
this pull request
Nov 10, 2024
|
I investigated and a proper fix was a bit more involved, so I added it myself. Thanks for the report and the PR! It helped a lot to know exactly where the problem was. |
|
awesome! glad to hear its fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The orchestrator parallel tasks were not working for me. I'm using neovim nightly if thats related, but when I run the vscode compound tasks in this repo only the first task runs. I noticed that the orchestrator strategy seems to take in "task names" just fine so I simply removed the check if the task definition is a table when converting the tasks to a list of a list.