Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure Modules and Fix font loading #3

Merged
merged 8 commits into from
Dec 24, 2023
Merged

Restructure Modules and Fix font loading #3

merged 8 commits into from
Dec 24, 2023

Conversation

giraugh
Copy link
Member

@giraugh giraugh commented Dec 23, 2023

Completed

  • Fix font loading when fontconfig binary is not available: now loads fonts from pwd in addition to system fonts
  • Restructure modules to reduce top level module count and move favicon image / server related functionality into their respective modules.
  • Loads fonts a single time when they are first used (using lazy static)
  • Stores the reqwest::Client object in axum state to avoid using OnceLock

@giraugh giraugh added the enhancement New feature or request label Dec 23, 2023
@giraugh giraugh requested a review from GRA0007 December 23, 2023 08:52
@giraugh giraugh self-assigned this Dec 23, 2023
GRA0007
GRA0007 approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@GRA0007 GRA0007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job refactoring

src/favicon_image/svg.rs Show resolved Hide resolved
@giraugh giraugh merged commit 3de7184 into main Dec 24, 2023
2 checks passed
@giraugh giraugh deleted the feat/mod-restructure branch December 24, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GRA0007 GRA0007 GRA0007 approved these changes

Assignees

@giraugh giraugh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giraugh @GRA0007