(#13) Default Get-VagrantEnvironment to get local environment #16
+34
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a flag for All environments
corbob
commented
Nov 21, 2021
|
|
||
| $environments = $environments[2..$($environments.Length - 4)] |
There was a problem hiding this comment.
This is basically not needed (and will be incorrect depending on the state of the vagrant environment). We're matching the regex below, all of the mentioned lines won't match the regex...
| $environments = $environments[2..$($environments.Length - 4)] | ||
|
|
||
| foreach($environment in $environments){ | ||
| if ($environment -match "^(?<name>[\w\-._]+)\s+(?<state>[\w]+)\s+\((?<provider>[\w]+)\)") { |
There was a problem hiding this comment.
This regex is subtley wrong... Two states that I've seen are not created which won't be picked up and running which will. Further: the name can include non-word characters like -.
|
@corbob I merged your other one, can you rebase this one and we can get it merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag for All environments
Fixes #13