Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller optimizations for custom parser since before incorrect force push #257

Conversation

lue-bird
Copy link
Contributor

@lue-bird lue-bird commented Aug 30, 2024

starts at #256 without the incorrect rebase into force-push.

This branch rebased, accepting all commits until git merge-base smaller-optimizations-for-custom-parser-since-before-incorrect-force-push upstream/master (which is a06ca8a68744204edd00d38de4c29970dfa85b44),
followed by a git rebase --onto upstream/master <the merge base> and finally a force-push.

In case this overwrites some changes you've done since or is otherwise problematic, please comment.

Before, I tried rebase -Xtheirs and rebase -X ours but these seem to have included commits from upstream/master that messed up future history from my branch.


actual PR content

  • before: 7583.10000000149 ms to do 100 runs => 75.8310000000149 ms/run
  • after: 2761.39999999851 ms to do 100 runs => 27.613999999985097 ms/run

(my old laptop broke down, so both of these are from my new one)

One change I really like is that now e.g. (\a -> { x = 3 }).x doesn't parse.

@jfmengels jfmengels merged commit 6ee4865 into stil4m:master Aug 30, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants