Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-17972 Removed dbname #1018

Merged
merged 9 commits into from
Mar 20, 2024
Merged

TDL-17972 Removed dbname #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d71396f
TDL-17972 Removed dbname
Anaelle1 Mar 20, 2024
c646e69
Revert "TDL-17972 Removed dbname"
Anaelle1 Mar 20, 2024
cda7d5b
TDL-17973 Removed DB
Anaelle1 Mar 20, 2024
fdc831e
Removed database field
Anaelle1 Mar 20, 2024
9fffbb2
Fixed doc
Anaelle1 Mar 20, 2024
038395f
Fixed doc
Anaelle1 Mar 20, 2024
4a3272a
Revert "TDL-17973 Removed DB"
Anaelle1 Mar 20, 2024
1517b1d
TDL-17973 Removed database field
Anaelle1 Mar 20, 2024
418ceff
Update mysql.yml
Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _data/ui/common/database-connections.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ field-names:
port: "Port"
username: "Username"
password: "Password"
database: "Database"

encryption: "Encryption Type"

Expand Down Expand Up @@ -64,7 +63,8 @@ field-copy:
port: |
Enter the port used by the {{ page.display_name }} instance. The default is `{{ page.port }}`.

username: "Enter the Stitch {{ page.display_name }} database user's username."
username: |
Enter the Stitch {{ page.display_name }} database user's username.

password: |
Enter the password for the Stitch {{ page.display_name }} database user.
Expand Down
15 changes: 1 addition & 14 deletions _data/ui/database-integration-settings/mysql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,6 @@ mysql: &standard-fields
version: "all"
copy: "{{ site.data.ui.common.database-connections.field-copy.password | flatify }}"

- &database
name: &database-name "{{ site.data.ui.common.database-connections.field-names.database }}"
version: "all"
copy: "{{ site.data.ui.common.database-connections.field-copy.optional-database | flatify }}"

- &server-id
name: &server-id-name "Server ID"
version: "all"
Expand All @@ -97,11 +92,6 @@ aurora-rds: &rds-fields
- *port
- *username
- *password
- name: *database-name
version: "all"
copy: |
Enter the name of the {{ integration.display_name }} database. Stitch will 'find' all databases you give the Stitch user access to - a default database is only used to complete the connection.


# -------------------------- #
# MAGENTO #
Expand All @@ -113,7 +103,6 @@ magento:
- *port
- *username
- *password
- *database


# -------------------------- #
Expand Down Expand Up @@ -143,7 +132,6 @@ cloudsql-mysql:
- *port
- *username
- *password
- *database
- *server-id


Expand All @@ -159,5 +147,4 @@ microsoft-azure-mysql:
Paste the **Server name** you retrieved in the [previous step](#locate-connection-details). This should be similar to `<database-name>.mysql.database.azure.com`.
- *port
- *username
- *password
- *database
- *password