Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for e-h v1.0.0-alpha #172

Closed

Conversation

ryankurte
Copy link
Contributor

@ryankurte ryankurte commented Jun 18, 2020

Blocked on e-h v1.0.0 release (rust-embedded/embedded-hal#177)

cc. @therealprof

src/timer.rs Outdated Show resolved Hide resolved
@maxekman
Copy link

maxekman commented Sep 13, 2020

Hi @ryankurte! How does this compare to my v1.0.0-alpha.1 branch #144? Can we merge/split the effort? I mainly want to be compatible with 1.0.x for the development of #145, but have provided the changes in a separate branch if the repo wants them.

@ryankurte
Copy link
Contributor Author

i somehow missed your PR when i made this one, they should be functionally equivalent. i haven't diffed em to check but, happy to close this in favour of yours and add the delta if there is anything missing.

@maxekman
Copy link

Sure, if that works for you @ryankurte. I'll see if I can finish it soon.

Do you think it could be useful to have a v1.0.0-dev branch for this repo so we can both merge any changes to it?

@maxekman
Copy link

There is now some new info about how to support both 0.2.x and 1.0.0-alpha: https://github.com/rust-embedded/embedded-hal#adding-support-for-an-embedded-hal--alpha-version-in-a-hal-implementation

@ryankurte
Copy link
Contributor Author

while it's possible to do this it's also pretty easy to build adaptors between versions, and to update things, so i definitely would not think it an expectation that both are supported.

@burrbull
Copy link
Member

Closed in favor of #388

@burrbull burrbull closed this Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants