Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NUCLEO-H753ZI board #2130

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Sep 15, 2023

Summary

This PR adds the support for NUCLEO-H753ZI board
This board is same to nucleo-h743zi2, as the user manual is same.
And the samples in the official Firmware Package are also same, so this board has compatibility with nucleo-h743zi2.

I'm not sure which is better, using existing variant file for H743ZI(2) or create a new one for H753ZI.
(In the first commit, I create a new variant file for H753ZI which is copied from H743ZI)

My board will deliver tomorrow. After the delivery, I can run tests but not sure what should be tested on the real board.

Validation

  • Ensure CI build is passed.
  • Run the tests on the board

@fpistm fpistm added the new variant Add support of new bard label Sep 15, 2023
@fpistm fpistm added this to the 2.7.0 milestone Sep 15, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Sep 16, 2023

This is the test result of CheckVariant
image

@fpistm fpistm mentioned this pull request Sep 19, 2023
83 tasks
@fpistm fpistm force-pushed the support-nucleoH753zi branch from 0de9d86 to c5afcc5 Compare September 19, 2023 06:59
@fpistm
Copy link
Member

fpistm commented Sep 19, 2023

Hi @yp05327
Thanks for the PR which is well formed.
I've just updated your PR to:

  • Fix NUM_DIGITAL_PINS
  • Update the README.md
  • Fix some indents
  • Squash commits

@fpistm fpistm merged commit 0fb3eff into stm32duino:main Sep 19, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
Development

Successfully merging this pull request may close these issues.

2 participants