Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix http response headers KPMG Pen test #1437

Open
wants to merge 1 commit into
base: release-2.4
Choose a base branch
from
Open

Fix http response headers KPMG Pen test #1437

wants to merge 1 commit into from

Conversation

fxiang1
Copy link
Contributor

@fxiang1 fxiang1 commented Jul 14, 2022 •
edited
Loading

Signed-off-by: Feng Xiang [email protected]

Issue:
https://github.com/stolostron/backlog/issues/23853

  • Add preload to sts

image

@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fxiang1
Copy link
Contributor Author

fxiang1 commented Jul 14, 2022

@pshickeydev Can you check the headers from the screenshot above to see if they meet the requirements from KPMG? Our app.js config is pretty much identical to the GRC one but I have no idea why we are still getting the duplicate headers. Wondering if that would be an issue?

Thanks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fxiang1