Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Hat Konflux update gatekeeper-operator-bundle-3-17 #123

Closed

Conversation

red-hat-konflux[bot]
Copy link

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Copy link

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign dhaiducek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhaiducek dhaiducek force-pushed the appstudio-gatekeeper-operator-bundle-3-17 branch 2 times, most recently from 6a147b0 to f06d031 Compare October 30, 2024 18:34
@dhaiducek
Copy link

Waiting for updates from:

@mprahl mprahl force-pushed the appstudio-gatekeeper-operator-bundle-3-17 branch from 07d2f6f to 59c5987 Compare November 4, 2024 21:46
@mprahl mprahl force-pushed the appstudio-gatekeeper-operator-bundle-3-17 branch from 59c5987 to 373860a Compare November 4, 2024 21:48
@mprahl
Copy link

mprahl commented Nov 4, 2024

@dhaiducek okay, I just rebased this PR. 🤞

@dhaiducek
Copy link

This PR is waiting on https://issues.redhat.com/browse/KFLUXBUGS-1638 to be resolved so we can tell Konflux that it's a bundle image that doesn't require additional checks.

In the meantime I need to figure out how to wire up the bundle so that it either is referencing Konflux's accepted image registries rather than quay.io and reference a digest. (Or determine whether it's acceptable to exclude either or both rules.)

@dhaiducek dhaiducek force-pushed the appstudio-gatekeeper-operator-bundle-3-17 branch 17 times, most recently from 9ed6285 to 1f34bf1 Compare November 8, 2024 15:03
@dhaiducek dhaiducek force-pushed the appstudio-gatekeeper-operator-bundle-3-17 branch 7 times, most recently from 74d89ed to ec92efb Compare November 8, 2024 18:41
@dhaiducek
Copy link

Okay, this PR is ready to go. The Enterprise Contract failure is because we're using a scratch image for the bundle, but that's a false positive that should be resolved by the Konflux bug I noted previously.

@dhaiducek
Copy link

For now, the bundle is pointing to the 3.17 images from the registry--it'll be a future TODO to set up the necessary nudges and image redirects to get everything to build properly.

JQ_BINARY="jq-linux-${ARCH}"

echo "Downloading ${JQ_BINARY}"
wget --no-verbose "https://github.com/jqlang/jq/releases/download/${JQ_VERSION}/${JQ_BINARY}" -O /usr/local/bin/jq
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have access to the internet during downstream builds and we shouldn't use any binaries not compiled during the build or available in an official Red Hat image.

Makefile Outdated

.PHONY: update-gatekeeper-image
update-gatekeeper-image: ## Update Gatekeeper image in manifests.
yq 'select(.kind == "Deployment") \
yq "select(.kind == \"Deployment\") \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have to write a Python script instead if yq isn't available in the UBI image.

@dhaiducek dhaiducek force-pushed the appstudio-gatekeeper-operator-bundle-3-17 branch 6 times, most recently from 9c52130 to 49d64db Compare November 20, 2024 16:49
@dhaiducek
Copy link

/retest

@dhaiducek dhaiducek force-pushed the appstudio-gatekeeper-operator-bundle-3-17 branch from 49d64db to 6f33ddb Compare December 2, 2024 16:57
Copy link

sonarqubecloud bot commented Dec 2, 2024

@red-hat-konflux red-hat-konflux bot closed this Dec 2, 2024
@red-hat-konflux red-hat-konflux bot deleted the appstudio-gatekeeper-operator-bundle-3-17 branch December 2, 2024 17:12
@dhaiducek
Copy link

dhaiducek commented Dec 2, 2024

Enterprise Contract is complaining that the task references were getting stale and I was getting lost on what was me and what came from Konflux. Plus I probably shouldn't be mucking with the default PR anyway since I'm not the author. I have these changes locally and will reset this pipeline, merge it (even though it'll probably fail initially), and then pile on my changes in a new PR to get it to green.

PR to reset pipeline:

PR to update the repo for Konflux:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants