-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Red Hat Konflux update gatekeeper-operator-bundle-3-17 #123
Red Hat Konflux update gatekeeper-operator-bundle-3-17 #123
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6a147b0
to
f06d031
Compare
Waiting for updates from: |
07d2f6f
to
59c5987
Compare
59c5987
to
373860a
Compare
@dhaiducek okay, I just rebased this PR. 🤞 |
This PR is waiting on https://issues.redhat.com/browse/KFLUXBUGS-1638 to be resolved so we can tell Konflux that it's a bundle image that doesn't require additional checks. In the meantime I need to figure out how to wire up the bundle so that it either is referencing Konflux's accepted image registries rather than |
9ed6285
to
1f34bf1
Compare
74d89ed
to
ec92efb
Compare
Okay, this PR is ready to go. The Enterprise Contract failure is because we're using a |
For now, the bundle is pointing to the 3.17 images from the registry--it'll be a future TODO to set up the necessary nudges and image redirects to get everything to build properly. |
build/install-dependencies.sh
Outdated
JQ_BINARY="jq-linux-${ARCH}" | ||
|
||
echo "Downloading ${JQ_BINARY}" | ||
wget --no-verbose "https://github.com/jqlang/jq/releases/download/${JQ_VERSION}/${JQ_BINARY}" -O /usr/local/bin/jq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have access to the internet during downstream builds and we shouldn't use any binaries not compiled during the build or available in an official Red Hat image.
Makefile
Outdated
|
||
.PHONY: update-gatekeeper-image | ||
update-gatekeeper-image: ## Update Gatekeeper image in manifests. | ||
yq 'select(.kind == "Deployment") \ | ||
yq "select(.kind == \"Deployment\") \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may have to write a Python script instead if yq
isn't available in the UBI image.
9c52130
to
49d64db
Compare
/retest |
Signed-off-by: red-hat-konflux <[email protected]>
Signed-off-by: red-hat-konflux <[email protected]>
Signed-off-by: red-hat-konflux <[email protected]>
Signed-off-by: red-hat-konflux <[email protected]>
Signed-off-by: Dale Haiducek <[email protected]>
Signed-off-by: Dale Haiducek <[email protected]>
Signed-off-by: Dale Haiducek <[email protected]>
49d64db
to
6f33ddb
Compare
Quality Gate passedIssues Measures |
Enterprise Contract is complaining that the task references were getting stale and I was getting lost on what was me and what came from Konflux. Plus I probably shouldn't be mucking with the default PR anyway since I'm not the author. I have these changes locally and will reset this pipeline, merge it (even though it'll probably fail initially), and then pile on my changes in a new PR to get it to green. PR to reset pipeline: PR to update the repo for Konflux: |
Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content
/ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization