Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update related images/Configuration nudges #135

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

dhaiducek
Copy link

  • Add containerImage annotation
  • Add operator to relatedImages

- Add `containerImage` annotation
- Add operator to `relatedImages`

Signed-off-by: Dale Haiducek <[email protected]>
@dhaiducek
Copy link
Author

/retest

@@ -6,6 +6,7 @@ metadata:
build.appstudio.redhat.com/commit_sha: '{{revision}}'
build.appstudio.redhat.com/target_branch: '{{target_branch}}'
pipelinesascode.tekton.dev/max-keep-runs: "3"
build.appstudio.openshift.io/build-nudge-files: "build/konflux-patch.sh"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! https://konflux-ci.dev/docs/how-tos/configuring/component-nudges/#customizing-nudging-prs

Do you know if this adds this file to the default patterns? It seems like it should, it would be a hassle to want to copy that documented default and then add our customization, but I want to check if you've confirmed the behavior.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it adds or replaces, but it also doesn't matter here since the script is the only thing that holds the relevant image references.

Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhaiducek dhaiducek merged commit d905920 into stolostron:release-3.17 Dec 12, 2024
8 of 12 checks passed
@dhaiducek dhaiducek deleted the konflux-nudges branch December 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants