Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dco check in github action. #283

Merged

Conversation

xuezhaojun
Copy link
Contributor

@xuezhaojun xuezhaojun commented Aug 22, 2023

We already have a dco check in prow, and github action doc check is not always align with prow's result.

It also blocks this PR from redaht TAP. #231

@xuezhaojun
Copy link
Contributor Author

/assign @zhujian7

@zhujian7
Copy link
Contributor

@qiujian16 WDYT?

@xuezhaojun
Copy link
Contributor Author

The latest blocked PR: #285

@qiujian16
Copy link
Contributor

/approve
/lgtm

@zhiweiyin318
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-merge-robot openshift-merge-robot merged commit a556f3f into stolostron:main Aug 28, 2023
@xuezhaojun xuezhaojun deleted the remove-dco-in-github-actions branch January 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants