Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go.mod to go 1.21. #304

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

xuezhaojun
Copy link
Contributor

@xuezhaojun xuezhaojun commented Jan 25, 2024

The 1.21 base images that dockerfiles used is not published yet, will upgrade them later.

The go version upgrade is required for hive deps upgrade task.

Signed-off-by: xuezhaojun <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@xuezhaojun
Copy link
Contributor Author

/assign @zhujian7

@zhujian7
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 25, 2024
Copy link

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xuezhaojun
Copy link
Contributor Author

/hold

It seems images for go 1.21 is all published, update the dockerfiles as well.

@openshift-merge-bot openshift-merge-bot bot merged commit c7c73ee into stolostron:main Jan 25, 2024
10 checks passed
@xuezhaojun xuezhaojun deleted the bump-go.mod-1.21 branch January 25, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants