Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flightctl support. #415

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add flightctl support. #415

merged 1 commit into from
Dec 11, 2024

Conversation

xuezhaojun
Copy link
Contributor

@xuezhaojun xuezhaojun commented Nov 7, 2024 •
edited
Loading

@xuezhaojun xuezhaojun force-pushed the add-flightctl-support branch 2 times, most recently from 7a413ef to 842192a Compare November 14, 2024 08:59
@xuezhaojun xuezhaojun force-pushed the add-flightctl-support branch 13 times, most recently from 0852407 to 96c48c9 Compare November 26, 2024 16:34
@xuezhaojun
Copy link
Contributor Author

/test check

@xuezhaojun xuezhaojun force-pushed the add-flightctl-support branch from 16ce277 to b416b2a Compare November 27, 2024 02:14
@xuezhaojun xuezhaojun requested a review from Copilot November 27, 2024 02:21
Copilot
Copilot AI reviewed Nov 27, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 11 changed files in this pull request and generated 2 suggestions.

Files not reviewed (5)
  • go.mod: Language not supported
  • pkg/controller/controller.go: Evaluated as low risk
  • pkg/controller/flightctl/flightctl.go: Evaluated as low risk
  • cmd/manager/main.go: Evaluated as low risk
  • pkg/controller/flightctl/manifests/serviceaccount.yml: Evaluated as low risk

pkg/controller/flightctl/managedclustercontroller.go Show resolved Hide resolved
pkg/controller/flightctl/manifests/clusterrolebinding_agentregistration.yml Outdated Show resolved Hide resolved
@xuezhaojun xuezhaojun force-pushed the add-flightctl-support branch 7 times, most recently from 56c8470 to 933d4cf Compare November 27, 2024 06:25
@xuezhaojun xuezhaojun changed the title WIP: Add flightctl support. [WIP] Add flightctl support. Nov 27, 2024
@xuezhaojun xuezhaojun force-pushed the add-flightctl-support branch from 93743ac to 424cee6 Compare November 27, 2024 09:08
@xuezhaojun xuezhaojun force-pushed the add-flightctl-support branch 2 times, most recently from 80d305b to 46986d4 Compare December 4, 2024 05:52
@xuezhaojun xuezhaojun requested a review from Copilot December 4, 2024 06:19
Copilot
Copilot AI reviewed Dec 4, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 15 changed files in this pull request and generated no suggestions.

Files not reviewed (9)
  • go.mod: Language not supported
  • pkg/controller/flightctl/flightctl_test.go: Evaluated as low risk
  • deploy/base/clusterrole.yaml: Evaluated as low risk
  • pkg/controller/controller.go: Evaluated as low risk
  • cmd/manager/main.go: Evaluated as low risk
  • pkg/helpers/helpers.go: Evaluated as low risk
  • pkg/controller/flightctl/flightctl.go: Evaluated as low risk
  • pkg/controller/flightctl/managedclustercontroller_test.go: Evaluated as low risk
  • pkg/controller/flightctl/manifests/serviceaccount.yml: Evaluated as low risk
@xuezhaojun xuezhaojun force-pushed the add-flightctl-support branch from 46986d4 to 182340c Compare December 4, 2024 07:09
@xuezhaojun xuezhaojun changed the title [WIP] Add flightctl support. Add flightctl support. Dec 4, 2024
@xuezhaojun xuezhaojun force-pushed the add-flightctl-support branch 5 times, most recently from 4052552 to 1c400db Compare December 4, 2024 14:09
@xuezhaojun
Copy link
Contributor Author

/test check

@xuezhaojun xuezhaojun closed this Dec 5, 2024
@xuezhaojun xuezhaojun reopened this Dec 5, 2024
@xuezhaojun
Copy link
Contributor Author

@qiujian16 , the PR is updated, pleaset take another look when you have time! Thanks!

@xuezhaojun
Copy link
Contributor Author

/assign @zhujian7 Please take a review when you get time, thanks!

qiujian16
qiujian16 reviewed Dec 9, 2024
View reviewed changes
go.mod Show resolved Hide resolved
pkg/controller/flightctl/flightctl.go Show resolved Hide resolved
pkg/controller/flightctl/flightctl.go Show resolved Hide resolved
@xuezhaojun xuezhaojun force-pushed the add-flightctl-support branch from 1c400db to edbad9e Compare December 10, 2024 03:37
@xuezhaojun xuezhaojun requested a review from qiujian16 December 10, 2024 03:37
@xuezhaojun
Support flightctl.
48c6049 
Signed-off-by: xuezhaojun <[email protected]>
@xuezhaojun xuezhaojun force-pushed the add-flightctl-support branch from edbad9e to 48c6049 Compare December 10, 2024 04:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@qiujian16
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 11, 2024
@zhujian7
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 80a8b96 into stolostron:main Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@qiujian16 qiujian16 Awaiting requested review from qiujian16

Assignees

@qiujian16 qiujian16

@zhujian7 zhujian7

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuezhaojun @qiujian16 @zhujian7