Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Remove the registration for the BYO case #1052

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

yanmxa
Copy link
Member

@yanmxa yanmxa commented Aug 12, 2024

Summary

Related issue(s)

Fixes # https://issues.redhat.com/browse/ACM-13198

Copy link

@clyang82
Copy link
Contributor

/lgtm
/retest

@yanmxa
Copy link
Member Author

yanmxa commented Aug 12, 2024

Kafka cluster not ready, retry again:

�[0;31m Timeout 600 seconds �[0m: kubectl get kafka kafka -n multicluster-global-hub -o jsonpath='{.status.listeners[1]}' | grep bootstrapServers

@yanmxa
Copy link
Member Author

yanmxa commented Aug 12, 2024

/retest

Copy link

openshift-ci bot commented Aug 12, 2024

@yanmxa: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanmxa
Copy link
Member Author

yanmxa commented Aug 12, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit cd57751 into stolostron:main Aug 12, 2024
14 checks passed
@yanmxa yanmxa deleted the br_byo_registration branch September 20, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants