✨ Add tranposrt config secret for agent and manager #1060
Conversation
yanmxa
force-pushed
the
br_update_agent_manager
branch
from
4c6bc28 to
8853cb4
Compare
yanmxa
force-pushed
the
br_update_agent_manager
branch
5 times, most recently
from
23ec6c9 to
ef57a4f
Compare
|
/retest |
|
/test test-e2e |
|
/override "ci/prow/sonarcloud" |
|
@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| c.consumerCancel() | ||
| } | ||
| c.consumerCtx, c.consumerCancel = context.WithCancel(ctx) | ||
| go func() { |
There was a problem hiding this comment.
If It's possible that mutiple request enter this go func() and start the consumer several time at the same time.
| return ctrl.Result{}, fmt.Errorf("failed to create the consumer: %w", err) | ||
| } | ||
| c.consumer = receiver | ||
| go func() { |
There was a problem hiding this comment.
Multiple request may enter this go routine and start it several times
|
/test test-e2e |
yanmxa
force-pushed
the
br_update_agent_manager
branch
from
e57aabc to
562bd22
Compare
|
/override ci/prow/sonarcloud |
|
@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "SonarCloud Code Analysis" |
|
@yanmxa: Overrode contexts on behalf of yanmxa: SonarCloud Code Analysis In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
It looks good to me, @clyang82 Please help to take a look |
| ConsumerConfig: &transport.KafkaConsumerConfig{}, | ||
| }, | ||
| IsManager: false, | ||
| EnableDatabaseOffset: false, |
There was a problem hiding this comment.
it is worth adding comments for those 2 fields.
| return fmt.Errorf("failed to add transport consumer to manager: %w", err) | ||
| } | ||
|
|
||
| func AddToManager(mgr ctrl.Manager, consumer transport.Consumer, agentConfig *config.AgentConfig) error { |
There was a problem hiding this comment.
var specControllerStarted bool
func AddToManager(...) {
if specControllerStarted {
return
}
specControllerStarted = true
}
|
|
||
| if err := cronjob.AddSchedulerToManager(ctx, mgr, managerConfig, enableSimulation); err != nil { | ||
| return nil, fmt.Errorf("failed to add scheduler to manager: %w", err) |
Signed-off-by: myan <[email protected]> fix the integration Signed-off-by: myan <[email protected]> fix the integration test Signed-off-by: myan <[email protected]> fix the ut Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
yanmxa
force-pushed
the
br_update_agent_manager
branch
from
562bd22 to
3a20bc0
Compare
Signed-off-by: myan <[email protected]>
|
/override ci/prow/sonarcloud |
|
@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "SonarCloud Code Analysis" |
|
@yanmxa: Overrode contexts on behalf of yanmxa: SonarCloud Code Analysis In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, yanmxa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
/override ci/prow/sonarcloud |
|
@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "SonarCloud Code Analysis" |
|
@yanmxa: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "SonarCloud Code Analysis" |
|
@yanmxa: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit ebcf16e
into
stolostron:main
Summary
Related issue(s)
Fixes #
References: #1045