-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Use Kafka KRaft #1250
✨ Use Kafka KRaft #1250
Conversation
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
/test images |
/test test-e2e |
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
/test test-e2e |
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
/test test-integration |
Signed-off-by: clyang82 <[email protected]>
Quality Gate passedIssues Measures |
@@ -219,8 +219,8 @@ func GetConfluentConfigMapByUser(c client.Client, namespace, clusterName, userNa | |||
cm := config.GetBasicConfigMap() | |||
for _, condition := range kafkaCluster.Status.Conditions { | |||
if *condition.Type == "Ready" && *condition.Status == "True" { | |||
clusterCaCert := kafkaCluster.Status.Listeners[1].Certificates[0] | |||
_ = cm.SetKey("bootstrap.servers", *kafkaCluster.Status.Listeners[1].BootstrapServers) | |||
clusterCaCert := kafkaCluster.Status.Listeners[0].Certificates[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two listeners for the kafka connection. the first one is internal, and the other is external. You mean only keep one type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. remove plain listener for Kafka to disable anonymous access.
Did you test if the upgrade works well? |
will handle the upgrade in a separate user story. |
It's a significant improvement in transport optimization, especially in its footprint! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, yanmxa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Use KRaft mode since it is GAed. besides it, also address the following issues in this PR:
Related issue(s)
Fixes # https://issues.redhat.com/browse/ACM-15625
Tests
make unit-tests
.make integration-test
.make e2e-test-all
.