Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use Kafka KRaft #1250

Merged
merged 16 commits into from
Dec 5, 2024
Merged

✨ Use Kafka KRaft #1250

merged 16 commits into from
Dec 5, 2024

Conversation

clyang82
Copy link
Contributor

@clyang82 clyang82 commented Nov 29, 2024

Summary

Use KRaft mode since it is GAed. besides it, also address the following issues in this PR:

  1. remove plain listener for Kafka to disable anonymous access

Related issue(s)

Fixes # https://issues.redhat.com/browse/ACM-15625

Tests

  • Unit/function tests have been added and incorporated into make unit-tests.
  • Integration tests have been added and incorporated into make integration-test.
  • E2E tests have been added and incorporated into make e2e-test-all.
  • List other manual tests you have done.

Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
@clyang82
Copy link
Contributor Author

clyang82 commented Dec 2, 2024

/test images

@clyang82
Copy link
Contributor Author

clyang82 commented Dec 2, 2024

/test test-e2e

Signed-off-by: clyang82 <[email protected]>
@clyang82
Copy link
Contributor Author

clyang82 commented Dec 3, 2024

/test test-e2e

@clyang82
Copy link
Contributor Author

clyang82 commented Dec 4, 2024

/test test-integration

@clyang82
Copy link
Contributor Author

clyang82 commented Dec 4, 2024

/assign @yanmxa @ldpliu

Signed-off-by: clyang82 <[email protected]>
@@ -219,8 +219,8 @@ func GetConfluentConfigMapByUser(c client.Client, namespace, clusterName, userNa
cm := config.GetBasicConfigMap()
for _, condition := range kafkaCluster.Status.Conditions {
if *condition.Type == "Ready" && *condition.Status == "True" {
clusterCaCert := kafkaCluster.Status.Listeners[1].Certificates[0]
_ = cm.SetKey("bootstrap.servers", *kafkaCluster.Status.Listeners[1].BootstrapServers)
clusterCaCert := kafkaCluster.Status.Listeners[0].Certificates[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two listeners for the kafka connection. the first one is internal, and the other is external. You mean only keep one type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. remove plain listener for Kafka to disable anonymous access.

@ldpliu
Copy link
Contributor

ldpliu commented Dec 4, 2024

Did you test if the upgrade works well?

@clyang82
Copy link
Contributor Author

clyang82 commented Dec 4, 2024

Did you test if the upgrade works well?

will handle the upgrade in a separate user story.

@yanmxa
Copy link
Member

yanmxa commented Dec 5, 2024

It's a significant improvement in transport optimization, especially in its footprint!

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2024
Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9331eb9 into stolostron:main Dec 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants