Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Clean the resource when the addon is not found #1260

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

yanmxa
Copy link
Member

@yanmxa yanmxa commented Dec 4, 2024

Summary

Related issue(s)

Fixes # https://issues.redhat.com/browse/ACM-16060

Tests

  • Unit/function tests have been added and incorporated into make unit-tests.
  • Integration tests have been added and incorporated into make integration-test.
  • E2E tests have been added and incorporated into make e2e-test-all.
  • List other manual tests you have done.

Signed-off-by: myan <[email protected]>
@yanmxa yanmxa changed the title [WIP] 🌱 clean the addon when it not found [WIP] 🌱 clean the resource when the addon is not found Dec 4, 2024
@openshift-ci openshift-ci bot added the approved label Dec 4, 2024
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
@yanmxa yanmxa changed the title [WIP] 🌱 clean the resource when the addon is not found 🌱 clean the resource when the addon is not found Dec 4, 2024
@yanmxa yanmxa changed the title 🌱 clean the resource when the addon is not found 🌱 Clean the resource when the addon is not found Dec 4, 2024
Copy link
Contributor

@clyang82 clyang82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82 clyang82 merged commit 7f0fb75 into stolostron:main Dec 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants