Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ":seedling: Bump go version to 1.23.4" #1286

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

clyang82
Copy link
Contributor

Reverts #1283 since Cachito cannot support 1.23.x.

Copy link

openshift-ci bot commented Dec 18, 2024

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Dec 18, 2024

@clyang82: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-integration 20ffcde link true /test test-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yanmxa
Copy link
Member

yanmxa commented Dec 18, 2024

/override ci/prow/test-integration
/override doc

Copy link

openshift-ci bot commented Dec 18, 2024

@yanmxa: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • doc

Only the following failed contexts/checkruns were expected:

  • ci/prow/gofmt
  • ci/prow/images
  • ci/prow/sonarcloud
  • ci/prow/test-e2e
  • ci/prow/test-integration
  • ci/prow/test-unit
  • dco
  • pull-ci-stolostron-multicluster-global-hub-main-gofmt
  • pull-ci-stolostron-multicluster-global-hub-main-images
  • pull-ci-stolostron-multicluster-global-hub-main-sonarcloud
  • pull-ci-stolostron-multicluster-global-hub-main-test-e2e
  • pull-ci-stolostron-multicluster-global-hub-main-test-integration
  • pull-ci-stolostron-multicluster-global-hub-main-test-unit
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/test-integration
/override doc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yanmxa
Copy link
Member

yanmxa commented Dec 18, 2024

/lgtm

Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanmxa yanmxa merged commit bd41d9e into main Dec 18, 2024
13 of 16 checks passed
@clyang82 clyang82 deleted the revert-1283-bump_go1.23 branch December 18, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants