Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 provide vendor version for inventory cluster #1301

Closed
wants to merge 1 commit into from

Conversation

yanmxa
Copy link
Member

@yanmxa yanmxa commented Dec 23, 2024

Summary

Related issue(s)

Fixes # https://issues.redhat.com/browse/ACM-16522

Tests

  • Unit/function tests have been added and incorporated into make unit-tests.
  • Integration tests have been added and incorporated into make integration-test.
  • E2E tests have been added and incorporated into make e2e-test-all.
  • List other manual tests you have done.

Copy link

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82
Copy link
Contributor

we already have the same logic to set vendorVersion in

switch clusterInfo.Status.KubeVendor {
case clusterinfov1beta1.KubeVendorOpenShift:
k8sCluster.ResourceData.KubeVendor = kessel.K8SClusterDetail_OPENSHIFT
k8sCluster.ResourceData.VendorVersion = clusterInfo.Status.DistributionInfo.OCP.Version
case clusterinfov1beta1.KubeVendorEKS:
k8sCluster.ResourceData.KubeVendor = kessel.K8SClusterDetail_EKS
k8sCluster.ResourceData.VendorVersion = clusterInfo.Status.Version
case clusterinfov1beta1.KubeVendorGKE:
k8sCluster.ResourceData.KubeVendor = kessel.K8SClusterDetail_GKE
k8sCluster.ResourceData.VendorVersion = clusterInfo.Status.Version
default:
k8sCluster.ResourceData.KubeVendor = kessel.K8SClusterDetail_KUBE_VENDOR_OTHER
k8sCluster.ResourceData.VendorVersion = clusterInfo.Status.Version
}

@clyang82 clyang82 closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants