Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some issue about upgrade #1303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ldpliu
Copy link
Contributor

@ldpliu ldpliu commented Dec 24, 2024

Summary

  1. Agent should start after transport ready
  2. Add an annotation in kafka cr in upgrade case. then identify the isNewKafkaCluster based on this annotation. With this, operator restart will not impact this field.

Related issue(s)

Fixes #
https://issues.redhat.com/browse/ACM-16797

Tests

  • Unit/function tests have been added and incorporated into make unit-tests.
  • Integration tests have been added and incorporated into make integration-test.
  • E2E tests have been added and incorporated into make e2e-test-all.
  • List other manual tests you have done.

Copy link

openshift-ci bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ldpliu
Once this PR has been reviewed and has the lgtm label, please assign morvencao for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ldpliu
Copy link
Contributor Author

ldpliu commented Dec 25, 2024

/cc @clyang82

@openshift-ci openshift-ci bot requested a review from clyang82 December 25, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant