Sync policy object only policy spec is changed #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meng Yan <[email protected]>
|
Could you update the description why we need this changes? Is it introduced by the code refactor? |
clyang82
reviewed
Apr 1, 2024
| @@ -23,7 +23,7 @@ func LaunchSubscriptionReportSyncer(ctx context.Context, mgr ctrl.Manager, agent | |||
| predicate := predicate.NewPredicateFuncs(func(object client.Object) bool { return true }) | |||
|
|
|||
| // emitter config | |||
| emitter := generic.ObjectEmitterWrapper(enum.SubscriptionReportType, nil, nil) | |||
| emitter := generic.ObjectEmitterWrapper(enum.SubscriptionReportType, nil, nil, false) | |||
There was a problem hiding this comment.
add TODO to handle it if needed.
Signed-off-by: myan <[email protected]>
Signed-off-by: myan <[email protected]>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, yanmxa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: myan [email protected]
Reference: https://issues.redhat.com/browse/ACM-10797
For the policy spec event, we only need to report the object when the generation(spec) is changed. And ignore the status updates.