Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ handle pending policies #883

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

ldpliu
Copy link
Contributor

@ldpliu ldpliu commented Apr 9, 2024

Summary

This pr handle pending policies in back-end and dashboards

Related issue(s)

https://issues.redhat.com/browse/ACM-10818
https://issues.redhat.com/browse/ACM-10817

image image image image

@ldpliu
Copy link
Contributor Author

ldpliu commented Apr 9, 2024

/retest

@ldpliu ldpliu force-pushed the handle-pending-policy branch from db221c8 to ecbd6d9 Compare April 9, 2024 09:12
@ldpliu ldpliu changed the title handle pending policies ✨ handle pending policies Apr 9, 2024
@ldpliu ldpliu force-pushed the handle-pending-policy branch 2 times, most recently from cd5b900 to 01a0c6b Compare April 10, 2024 00:57
@ldpliu
Copy link
Contributor Author

ldpliu commented Apr 11, 2024

/cc @clyang82 @yanmxa

@openshift-ci openshift-ci bot requested review from clyang82 and yanmxa April 11, 2024 02:53
@@ -13,6 +13,7 @@ DO $$ BEGIN
CREATE TYPE local_status.compliance_type AS ENUM (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to consider the upgrade?

@ldpliu ldpliu force-pushed the handle-pending-policy branch from 01a0c6b to 2cd2309 Compare April 11, 2024 07:02
@ldpliu
Copy link
Contributor Author

ldpliu commented Apr 11, 2024

/retest

Copy link
Contributor

@clyang82 clyang82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Apr 11, 2024
Copy link

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, ldpliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@openshift-merge-bot openshift-merge-bot bot merged commit 94133c2 into stolostron:main Apr 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants