Fix tests for BVT testing (#1598)

* update tests to ignore clusters that dont have observability addon installed Signed-off-by: Coleen Iona Quadros <[email protected]> * update tests to ignore clusters that dont have observability addon installed Signed-off-by: Coleen Iona Quadros <[email protected]> * force add on obervability label for kind Signed-off-by: Coleen Iona Quadros <[email protected]> * add logs to tests Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]>
stolostron · Sep 4, 2024 · 40d69e8 · 40d69e8
1 parent 578db6d
commit 40d69e8
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/tests/pkg/utils/mco_managedcluster.go b/tests/pkg/utils/mco_managedcluster.go
@@ -7,6 +7,7 @@ package utils
 import (
 	"context"
 	"errors"
+	"os"
 
 	goversion "github.com/hashicorp/go-version"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -52,12 +53,13 @@ func ListManagedClusters(opt TestOptions) ([]string, error) {
 		metadata := obj.Object["metadata"].(map[string]interface{})
 		name := metadata["name"].(string)
 		labels := metadata["labels"].(map[string]interface{})
+		if os.Getenv("IS_KIND_ENV") == "true" {
+			// We do not have the obs add on label added in kind cluster
+			clusterNames = append(clusterNames, name)
+			continue
+		}
 		if labels != nil {
-			obsControllerStr := ""
-			if obsController, ok := labels["feature.open-cluster-management.io/addon-observability-controller"]; ok {
-				obsControllerStr = obsController.(string)
-			}
-			if obsControllerStr != "unreachable" {
+			if obsController, ok := labels["feature.open-cluster-management.io/addon-observability-controller"]; ok && obsController.(string) != "unreachable" {
 				clusterNames = append(clusterNames, name)
 			}
 		}