Skip to content

Commit

Permalink
clean comments
Browse files Browse the repository at this point in the history
Signed-off-by: Coleen Iona Quadros <[email protected]>
  • Loading branch information
coleenquadros committed Oct 18, 2023
1 parent 0020bcb commit ca1cbf5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -947,7 +947,6 @@ func cleanUpClusterScopedResources(
return nil
}

// Delete the PrometheusRule in openshift-monitoring namespace
func (r *MultiClusterObservabilityReconciler) deleteSpecificPrometheusRule(ctx context.Context) error {
promRule := &monitoringv1.PrometheusRule{}
err := r.Client.Get(ctx, client.ObjectKey{Name: "acm-observability-alert-rules",
Expand All @@ -967,7 +966,6 @@ func (r *MultiClusterObservabilityReconciler) deleteSpecificPrometheusRule(ctx c
return nil
}

// Delete the ServiceMonitor in openshift-monitoring namespace
func (r *MultiClusterObservabilityReconciler) deleteServiceMonitorInOpenshiftMonitoringNamespace(ctx context.Context) error {
serviceMonitorList := &monitoringv1.ServiceMonitorList{}
err := r.Client.List(ctx, serviceMonitorList, client.InNamespace("openshift-monitoring"))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,6 @@ func createPersistentVolumeClaim(name, namespace, pvcName string) *corev1.Persis
}
}

// Test Prometheus Rules removed from open shift monitoring namespace
func TestPrometheusRulesRemovedFromOpenshiftMonitoringNamespace(t *testing.T) {
promRule := &monitoringv1.PrometheusRule{
ObjectMeta: metav1.ObjectMeta{
Expand Down Expand Up @@ -990,7 +989,6 @@ func TestPrometheusRulesRemovedFromOpenshiftMonitoringNamespace(t *testing.T) {
}
}

// Test Service Monitor removed from open shift monitoring namespace
func TestServiceMonitorRemovedFromOpenshiftMonitoringNamespace(t *testing.T) {
sm := &monitoringv1.ServiceMonitor{
ObjectMeta: metav1.ObjectMeta{
Expand Down

0 comments on commit ca1cbf5

Please sign in to comment.