Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add etcd metrics support for microshift #1460

Closed
wants to merge 12 commits into from
Closed

Add etcd metrics support for microshift #1460

wants to merge 12 commits into from

Conversation

thibaultmg
Copy link
Contributor

No description provided.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 31, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@thibaultmg thibaultmg force-pushed the add_etcd_target_microshift branch 2 times, most recently from 2fd068e to ffd6fab Compare June 3, 2024 12:48
@thibaultmg thibaultmg marked this pull request as ready for review June 3, 2024 12:53
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 5, 2024
View reviewed changes
operators/multiclusterobservability/manifests/endpoint-observability/role.yaml
@@ -161,8 +161,7 @@
- cronjobs
- jobs
verbs:
- list
- watch
- '*'

Check warning

Code scanning / SonarCloud

Wildcards should not be used to define RBAC permissions

<!--SONAR_ISSUE_KEY:AY_nTDqzpQrLtpWYNkEi-->Do not use wildcards when defining RBAC permissions. <p>See more on <a href="https://sonarcloud.io/project/issues?id=open-cluster-management_multicluster-observability-operator&issues=AY_nTDqzpQrLtpWYNkEi&open=AY_nTDqzpQrLtpWYNkEi&pullRequest=1460">SonarCloud</a></p>
@thibaultmg thibaultmg marked this pull request as draft June 12, 2024 11:34
@thibaultmg thibaultmg force-pushed the add_etcd_target_microshift branch from f242965 to af2e428 Compare June 18, 2024 10:10
@thibaultmg thibaultmg marked this pull request as ready for review June 18, 2024 12:35
@thibaultmg
Copy link
Contributor Author

/retest

1 similar comment
@thibaultmg
Copy link
Contributor Author

/retest

thibaultmg added 10 commits June 26, 2024 15:19
@thibaultmg
Add resources for etcd
de25670 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
init metrics collector unit tests
2b3b775 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
fix addon tests and mc cronjob
1d9518b 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
add status update
a395b4d 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
set privileged to cronjob, add retry on update
c76a4cb 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
remove prom var
2732d8f 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
cleaning
ad1fea5 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
clean diffs
615e083 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
post rebase fix
7330b67 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg
Add resources for etcd
b76ed53 
Signed-off-by: Thibault Mange <[email protected]>
@thibaultmg thibaultmg force-pushed the add_etcd_target_microshift branch from 54e929f to b76ed53 Compare June 28, 2024 08:53
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
53.8% Coverage on New Code (required ≥ 70%)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 1, 2024

@thibaultmg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 2069f88 link true /test sonarcloud
ci/prow/test-e2e 2069f88 link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@thibaultmg thibaultmg closed this Jul 24, 2024
@thibaultmg
Copy link
Contributor Author

Superseded by #1550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved dco-signoff: yes needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thibaultmg @openshift-merge-robot