Get Oauth proxy image from ImageStreams resource #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-kind |
|
local testing -> |
|
/retest-required |
|
/test e2e-kind |
|
/retest |
|
/test e2e-kind |
coleenquadros
force-pushed
the
oauth_proxy_image
branch
from
e59ebd7 to
ffe144e
Compare
|
/retest |
|
/retest |
|
/test test-e2e |
|
/retest |
coleenquadros
force-pushed
the
oauth_proxy_image
branch
2 times, most recently
from
16eba95 to
4f7aded
Compare
coleenquadros
force-pushed
the
oauth_proxy_image
branch
from
79d9d8d to
d3940c2
Compare
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
|
/retest |
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
|
/retest-required |
|
/retest |
Signed-off-by: Coleen Iona Quadros <[email protected]>
|
/test test-e2e |
Signed-off-by: Coleen Iona Quadros <[email protected]>
|
|
@coleenquadros: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test test-e2e |
coleenquadros
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coleenquadros, philipgough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 798d027
into
stolostron:main
20 of 21 checks passed
JoaoBraveCoding
pushed a commit
to JoaoBraveCoding/multicluster-observability-operator
that referenced
this pull request
Sep 9, 2024
* get oauth proxy image from image streams Signed-off-by: Coleen Iona Quadros <[email protected]> * update test Signed-off-by: Coleen Iona Quadros <[email protected]> * lint Signed-off-by: Coleen Iona Quadros <[email protected]> * lint Signed-off-by: Coleen Iona Quadros <[email protected]> * lint Signed-off-by: Coleen Iona Quadros <[email protected]> * Update Konflux to run on main branch (stolostron#1590) * Update registry.access.redhat.com/ubi9/go-toolset Docker digest to 5049a9d (stolostron#1546) Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com> * Red Hat Konflux update endpoint-monitoring-operator-acm-212 (stolostron#1541) * Red Hat Konflux update endpoint-monitoring-operator-acm-212 Signed-off-by: red-hat-konflux <[email protected]> * update builder Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux <[email protected]> Co-authored-by: Coleen Iona Quadros <[email protected]> * Red Hat Konflux update grafana-dashboard-loader-acm-212 (stolostron#1542) * Red Hat Konflux update grafana-dashboard-loader-acm-212 Signed-off-by: red-hat-konflux <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux <[email protected]> Co-authored-by: Coleen Iona Quadros <[email protected]> * Red Hat Konflux update metrics-collector-acm-212 (stolostron#1543) * Red Hat Konflux update metrics-collector-acm-212 Signed-off-by: red-hat-konflux <[email protected]> * update build Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux <[email protected]> Co-authored-by: Coleen Iona Quadros <[email protected]> * Red Hat Konflux update rbac-query-proxy-acm-212 (stolostron#1545) * Red Hat Konflux update rbac-query-proxy-acm-212 Signed-off-by: red-hat-konflux <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux <[email protected]> Co-authored-by: Coleen Iona Quadros <[email protected]> * Red Hat Konflux update multicluster-observability-operator-acm-212 (stolostron#1544) * Red Hat Konflux update multicluster-observability-operator-acm-212 Signed-off-by: red-hat-konflux <[email protected]> * Update Dockerfile Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update build Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux <[email protected]> Co-authored-by: Coleen Iona Quadros <[email protected]> * Update Konflux references Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> * make target branch main for pull request Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux <[email protected]> lint Signed-off-by: Coleen Iona Quadros <[email protected]> lint Signed-off-by: Coleen Iona Quadros <[email protected]> ACM-12794: forward auth header to datasource (stolostron#1589) * ACM-12794: forward auth header to datasource This allows rbac-query-proxy to authentication against obs-api. This is needed as Grafana no longer automatically forwards the header (and for now only does so in our patched Grafana version). Signed-off-by: Jacob Baungard Hansen <[email protected]> * Just forward access token We can infer the username, so I think just forwarding what we actually need might make this slightly more resiliant to future Grafana changes. Signed-off-by: Jacob Baungard Hansen <[email protected]> --------- Signed-off-by: Jacob Baungard Hansen <[email protected]> update Signed-off-by: Coleen Iona Quadros <[email protected]> update Signed-off-by: Coleen Iona Quadros <[email protected]> Revert "Avoid Concurrent writes to ManagedClusterList (stolostron#1516)" This reverts commit d642b5f. update Signed-off-by: Coleen Iona Quadros <[email protected]> * remove logs Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * remove log Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]>
JoaoBraveCoding
pushed a commit
to JoaoBraveCoding/multicluster-observability-operator
that referenced
this pull request
Sep 9, 2024
* get oauth proxy image from image streams Signed-off-by: Coleen Iona Quadros <[email protected]> * update test Signed-off-by: Coleen Iona Quadros <[email protected]> * lint Signed-off-by: Coleen Iona Quadros <[email protected]> * lint Signed-off-by: Coleen Iona Quadros <[email protected]> * lint Signed-off-by: Coleen Iona Quadros <[email protected]> * Update Konflux to run on main branch (stolostron#1590) * Update registry.access.redhat.com/ubi9/go-toolset Docker digest to 5049a9d (stolostron#1546) Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com> * Red Hat Konflux update endpoint-monitoring-operator-acm-212 (stolostron#1541) * Red Hat Konflux update endpoint-monitoring-operator-acm-212 Signed-off-by: red-hat-konflux <[email protected]> * update builder Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux <[email protected]> Co-authored-by: Coleen Iona Quadros <[email protected]> * Red Hat Konflux update grafana-dashboard-loader-acm-212 (stolostron#1542) * Red Hat Konflux update grafana-dashboard-loader-acm-212 Signed-off-by: red-hat-konflux <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux <[email protected]> Co-authored-by: Coleen Iona Quadros <[email protected]> * Red Hat Konflux update metrics-collector-acm-212 (stolostron#1543) * Red Hat Konflux update metrics-collector-acm-212 Signed-off-by: red-hat-konflux <[email protected]> * update build Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux <[email protected]> Co-authored-by: Coleen Iona Quadros <[email protected]> * Red Hat Konflux update rbac-query-proxy-acm-212 (stolostron#1545) * Red Hat Konflux update rbac-query-proxy-acm-212 Signed-off-by: red-hat-konflux <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux <[email protected]> Co-authored-by: Coleen Iona Quadros <[email protected]> * Red Hat Konflux update multicluster-observability-operator-acm-212 (stolostron#1544) * Red Hat Konflux update multicluster-observability-operator-acm-212 Signed-off-by: red-hat-konflux <[email protected]> * Update Dockerfile Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update build Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux <[email protected]> Co-authored-by: Coleen Iona Quadros <[email protected]> * Update Konflux references Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> * make target branch main for pull request Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux <[email protected]> lint Signed-off-by: Coleen Iona Quadros <[email protected]> lint Signed-off-by: Coleen Iona Quadros <[email protected]> ACM-12794: forward auth header to datasource (stolostron#1589) * ACM-12794: forward auth header to datasource This allows rbac-query-proxy to authentication against obs-api. This is needed as Grafana no longer automatically forwards the header (and for now only does so in our patched Grafana version). Signed-off-by: Jacob Baungard Hansen <[email protected]> * Just forward access token We can infer the username, so I think just forwarding what we actually need might make this slightly more resiliant to future Grafana changes. Signed-off-by: Jacob Baungard Hansen <[email protected]> --------- Signed-off-by: Jacob Baungard Hansen <[email protected]> update Signed-off-by: Coleen Iona Quadros <[email protected]> update Signed-off-by: Coleen Iona Quadros <[email protected]> Revert "Avoid Concurrent writes to ManagedClusterList (stolostron#1516)" This reverts commit d642b5f. update Signed-off-by: Coleen Iona Quadros <[email protected]> * remove logs Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * update Signed-off-by: Coleen Iona Quadros <[email protected]> * remove log Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ACM-12538
Global Hub Ref PR - stolostron/multicluster-global-hub#1010
stolostron/multicluster-global-hub#1042