[ACM-13266] - Enable mounting of arbitrary Secrets by alertmanager #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
dco-signoff: yes
and removed
dco-signoff: no
do-not-merge/work-in-progress
labels
|
/retest |
|
/test test-e2e |
philipgough
force-pushed
the
ACM-13266
branch
2 times, most recently
from
20b639c to
98a819a
Compare
|
/test pr-image-mirror-rbac-query-proxy |
|
/retest |
philipgough
changed the title
saswatamcode
reviewed
Sep 2, 2024
operators/multiclusterobservability/pkg/rendering/renderer_alertmanager.go
Show resolved
Hide resolved
Signed-off-by: Philip Gough <[email protected]>
Signed-off-by: Philip Gough <[email protected]>
Signed-off-by: Philip Gough <[email protected]>
…advanced config Signed-off-by: Philip Gough <[email protected]>
philipgough
force-pushed
the
ACM-13266
branch
from
fc0662a to
7dd2316
Compare
|
|
/test test-e2e |
saswatamcode
approved these changes
Sep 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: philipgough, saswatamcode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JoaoBraveCoding
pushed a commit
to JoaoBraveCoding/multicluster-observability-operator
that referenced
this pull request
Sep 9, 2024
…tolostron#1593) * bingo: Update controller-gen/tools versions Signed-off-by: Philip Gough <[email protected]> * make: generate Signed-off-by: Philip Gough <[email protected]> * make: bundle Signed-off-by: Philip Gough <[email protected]> * mco:alertmanager: Allow mounting of arbitrary secrets via volumes in advanced config Signed-off-by: Philip Gough <[email protected]> --------- Signed-off-by: Philip Gough <[email protected]>
JoaoBraveCoding
pushed a commit
to JoaoBraveCoding/multicluster-observability-operator
that referenced
this pull request
Sep 9, 2024
…tolostron#1593) * bingo: Update controller-gen/tools versions Signed-off-by: Philip Gough <[email protected]> * make: generate Signed-off-by: Philip Gough <[email protected]> * make: bundle Signed-off-by: Philip Gough <[email protected]> * mco:alertmanager: Allow mounting of arbitrary secrets via volumes in advanced config Signed-off-by: Philip Gough <[email protected]> --------- Signed-off-by: Philip Gough <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ACM-13266 - allows a user to mount Secrets in alertmanager from the
advancedConfigoption in MCO.Following the pattern of prometheus-operator, Secrets will be mounted as a volume named secret-. Secrets are mounted into /etc/alertmanager/secrets/ in the 'alertmanager' container.