Add RHACM Openshift Virtualization Dashboards #1603
Conversation
Signed-off-by: Leonardo Araujo <[email protected]>
| "targets": [ | ||
| { | ||
| "exemplar": true, | ||
| "expr": "csv_succeeded{name=~\".*hyperconverged.*\", cluster=~\"$cluster\"}", |
There was a problem hiding this comment.
We can replace with acm_managed_cluster_labels since the OpenShift Virtualization version aligns with OpenShift version.
There was a problem hiding this comment.
Shirly, the major version is aligned, but the minor version will not always be the same, so we chose to use csv_succeed to present the OCP Virt version.
There was a problem hiding this comment.
+1 In that case I suggest to limit the metric collection to csv_succeeded{name=~".*hyperconverged.*"} instead of just csv_succeeded if its not needed by other dashboards. WDTY?
There was a problem hiding this comment.
I understood that the suggestion is not directly related to the dashboard, but rather the custom-metrics-allowlist configmap, the csv_succeed metric already collected by default and is not part of the custom metrics configmap.
There was a problem hiding this comment.
Sorry, I forgot this was collected also for other dashboards.
|
/test test-e2e |
|
We are still working making changes to the dashboards. /hold |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
There was a problem hiding this comment.
LGTM pending we can test these in a live environment - one note is all the dashboards need a unique UUID as per this PR
https://github.com/stolostron/multicluster-observability-operator/pull/1566/files
So that when they link to themselves it's a fixed URL :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leoaaraujo, moadz, philipgough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
Added Grafana Dashboards for Openshift Virtualization managed by ACM.