Update Virtualization descriptions #1650
Conversation
...iclusterobservability/manifests/base/grafana/dash-acm-openshift-virtualization-overview.yaml
Outdated
Show resolved
Hide resolved
...iclusterobservability/manifests/base/grafana/dash-acm-openshift-virtualization-overview.yaml
Outdated
Show resolved
Hide resolved
sradco
force-pushed
the
update_virtualisation_dashboards_texts
branch
from
7b61118 to
9ee67e6
Compare
There was a problem hiding this comment.
Couple of more comments. @moadz do you have thoughts about the title of the dashboards being updated as I suggested in the previous PR?
...iclusterobservability/manifests/base/grafana/dash-acm-openshift-virtualization-overview.yaml
Outdated
Show resolved
Hide resolved
...iclusterobservability/manifests/base/grafana/dash-acm-openshift-virtualization-overview.yaml
Outdated
Show resolved
Hide resolved
|
@dockerymick I'm not too worried about the titles because we would need to change the existing dashboards to follow the same format. This is fine for now. @sradco are you able to action the outstanding doc items apart from the titles and I can get this merged. |
openshift-ci
bot
added
lgtm
approved
dco-signoff: no
and removed
lgtm
dco-signoff: yes
labels
So can the titles updates be made during a refresh or z-stream release? They really need to be improved |
Signed-off-by: Shirly Radco <[email protected]> Update operators/multiclusterobservability/manifests/base/grafana/dash-acm-openshift-virtualization-overview.yaml Co-authored-by: Mikela Jackson <[email protected]> Update operators/multiclusterobservability/manifests/base/grafana/dash-acm-openshift-virtualization-overview.yaml Co-authored-by: Mikela Jackson <[email protected]>
moadz
force-pushed
the
update_virtualisation_dashboards_texts
branch
from
006439f to
6ec50c7
Compare
|
|
/retest |
|
/lgmt |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moadz, sradco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sradco: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Update Virtualization descriptions based on the docs team review.
Signed-off-by: Shirly Radco [email protected]