Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spec comparison for observatorium #1652

Merged
merged 17 commits into from
Nov 21, 2024
Merged

Fix spec comparison for observatorium #1652

merged 17 commits into from
Nov 21, 2024

Conversation

coleenquadros
Copy link
Contributor

@coleenquadros coleenquadros commented Oct 24, 2024 •
edited
Loading

https://issues.redhat.com/browse/ACM-14867
https://issues.redhat.com/browse/ACM-15050

Removed global var to check for custom rules config map as that could lead to a race condition to incorrectly intrepret the addition/removal of custom rules

@coleenquadros coleenquadros changed the title Fix spec comaprison for observatorium Fix spec comparison for observatorium Oct 24, 2024
@coleenquadros
Copy link
Contributor Author

/retest

@coleenquadros
Copy link
Contributor Author

/test test-unit

@coleenquadros
Copy link
Contributor Author

/retest

2 similar comments
@coleenquadros
Copy link
Contributor Author

/retest

@coleenquadros
Copy link
Contributor Author

/retest

saswatamcode
saswatamcode approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 25, 2024
philipgough
philipgough approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@coleenquadros
Copy link
Contributor Author

/retest

1 similar comment
@coleenquadros
Copy link
Contributor Author

/retest

@coleenquadros
Copy link
Contributor Author

/test e2e-kind

@coleenquadros
Copy link
Contributor Author

/test test-e2e

@coleenquadros
Copy link
Contributor Author

/test e2e-kind

@coleenquadros
Copy link
Contributor Author

/test test-e2e

@openshift-ci openshift-ci bot removed the lgtm label Nov 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 4, 2024

New changes are detected. LGTM label has been removed.

@coleenquadros
Copy link
Contributor Author

/test e2e-kind

@coleenquadros
Copy link
Contributor Author

/test test-e2e

1 similar comment
@coleenquadros
Copy link
Contributor Author

/test test-e2e

@coleenquadros
Copy link
Contributor Author

/retest

@coleenquadros
Copy link
Contributor Author

/test test-e2e

1 similar comment
@coleenquadros
Copy link
Contributor Author

/test test-e2e

@coleenquadros coleenquadros changed the base branch from main to release-2.12 November 11, 2024 07:59
@coleenquadros
update comp (stolostron#1660)
3899bfe 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
fix spec comaprison for observatorium
59c893e 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
lint
4c1fa60 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
add test
98f276b 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
run only alert
99b57ca 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
test
3a272c4 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
add logs
a5e8dc8 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
use deep equal
e6250b3 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
logs
4288b4a 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
dont reply on global var for customr rules cm check
7d04c1c 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
lib
da49526 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
remove ginkgo focus
1fcb020 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
remove ginkgo focus
a8aea6c 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
logs
cd428bc 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
use deep equal
8fe4d4b 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
remove ginkgo focus
0d4871e 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
remove logs
97573d3 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, philipgough, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [coleenquadros,philipgough,saswatamcode]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@coleenquadros
Copy link
Contributor Author

/retest-required

@coleenquadros
Copy link
Contributor Author

/test test-e2e

1 similar comment
@coleenquadros
Copy link
Contributor Author

/test test-e2e

@moadz
Copy link
Contributor

moadz commented Nov 20, 2024

/retest

4 similar comments
@moadz
Copy link
Contributor

moadz commented Nov 20, 2024

/retest

@moadz
Copy link
Contributor

moadz commented Nov 20, 2024

/retest

@moadz
Copy link
Contributor

moadz commented Nov 20, 2024

/retest

@moadz
Copy link
Contributor

moadz commented Nov 21, 2024

/retest

@moadz moadz merged commit fbd23aa into stolostron:release-2.12 Nov 21, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

@philipgough philipgough philipgough approved these changes

Assignees

@philipgough philipgough

@saswatamcode saswatamcode

Labels
approved dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coleenquadros @moadz @philipgough @saswatamcode