Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix status update and cm predicate #1664

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

thibaultmg
Copy link
Contributor

@thibaultmg thibaultmg commented Nov 7, 2024

This PR:

  • Introduces a new predicate for the configmap, only triggering reconciles when the data changes.
  • Only updates the status if the collector deployment was actually updated.

https://issues.redhat.com/browse/ACM-15458

@thibaultmg thibaultmg changed the title fix staus update and cm predicate fix status update and cm predicate Nov 7, 2024
Copy link
Contributor

@jacobbaungard jacobbaungard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jacobbaungard,thibaultmg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jacobbaungard
Copy link
Contributor

/retest

3 similar comments
@jacobbaungard
Copy link
Contributor

/retest

@jacobbaungard
Copy link
Contributor

/retest

@jacobbaungard
Copy link
Contributor

/retest

Signed-off-by: Thibault Mange <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Nov 15, 2024
Copy link

openshift-ci bot commented Nov 15, 2024

New changes are detected. LGTM label has been removed.

@thibaultmg
Copy link
Contributor Author

/retest

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
39.1% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

Copy link

openshift-ci bot commented Nov 21, 2024

@thibaultmg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 8460a3f link false /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thibaultmg thibaultmg merged commit 7a1337e into stolostron:main Nov 22, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants