Render: fail if no oauth image is found

[jacobbaungard]

For some unknown reason, during upgrades from ACM 2.11, the template image is briefly used, instead of the image from the openshift imagestream. The template image is not available in disconnected environments, and as a result causes the pods be unable to come up.

This is a problem especially for alertmanager. Because of it being a statefulset when it gets into the bad state, with the wrong image, it doesn't automatically recover on the next reconcile. This requires manual intervention to fix.

Instead with this PR, we make the reconcile fail if we do not find the oauth image. This will make it retry later, when the imagestream is able to be found.

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

[jacobbaungard]

/test test-e2e

[jacobbaungard]

/test test-e2e

[jacobbaungard]

Note this causes reconciles to fail (intentionally) if we cannot find the imagestream. Not sure if there is a more graceful method? It will basically keep all images on the older versions during an upgrade, until the we can get the correct image. It seems we will keep trying to reconcile until it works, so probably works OK.

Error:

2024-11-15T16:06:02.194Z ERROR controller_multiclustermonitoring Failed to render multiClusterMonitoring templates {"Request.Namespace": "open-cluster-management", "Request.Name": "mch-updated-request", "error": "failed to get OAuth image for Grafana"}
github.com/stolostron/multicluster-observability-operator/operators/multiclusterobservability/controllers/multiclusterobservability.(*MultiClusterObservabilityReconciler).Reconcile
/workspace/operators/multiclusterobservability/controllers/multiclusterobservability/multiclusterobservability_controller.go:280
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:114
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:311
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:261
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:222
2024-11-15T16:06:02.194Z ERROR Reconciler error {"controller": "multiclusterobservability", "controllerGroup": "observability.open-cluster-management.io", "controllerKind": "MultiClusterObservability", "MultiClusterObservability": {"name":"mch-updated-request","namespace":"open-cluster-management"}, "namespace": "open-cluster-management", "name": "mch-updated-request", "reconcileID": "8fc754de-955e-4748-8faa-233d48b97297", "error": "failed to get OAuth image for Grafana"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:324
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:261
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:222

[jacobbaungard]

/test test-e2e

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jacobbaungard,saswatamcode]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jacobbaungard]

/cherrypick release-2.13

[openshift-cherrypick-robot]

@jacobbaungard: once the present PR merges, I will cherry-pick it on top of release-2.13 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jacobbaungard]

/override "SonarCloud Code Analysis"

[openshift-ci]

@jacobbaungard: Overrode contexts on behalf of jacobbaungard: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jacobbaungard]

/override "ci/prow/sonarcloud"

[openshift-ci]

@jacobbaungard: Overrode contexts on behalf of jacobbaungard: ci/prow/sonarcloud

In response to this:

/override "ci/prow/sonarcloud"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@jacobbaungard: new pull request created: #1671

In response to this:

/cherrypick release-2.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jacobbaungard]

/cherrypick main

[openshift-cherrypick-robot]

@jacobbaungard: new pull request created: #1672

In response to this:

/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.