Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-16286/backport 2.12]: Ensure MCO spec addon options are propagated correctly #1725

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

saswatamcode
Copy link
Member

#1718)

  • ACM-16286: Ensure MCO spec addon options are propagated correctly

  • ACM-16286: Update all observabilityaddon manifests

  • ACM-16286: Ensure hub and spoke obsaddon are synced based on spec

  • ACM-16286: Allow customizing ObsAddon in spoke ns

  • Add addon source annotation

  • Add handling for empty map

  • Add handling for nil maps

  • Add annotation predicate, update in mco mode

  • Fix unit test, make addon annotation constant

  • Update comment

  • Address comments

  • Use semantic deepequal, add test for setter

  • Set spoke addon correctly after comparison


…tolostron#1718)

* [ACM-16286]: Ensure MCO spec addon options are propagated correctly

Signed-off-by: Saswata Mukherjee <[email protected]>

* [ACM-16286]: Update all observabilityaddon manifests

Signed-off-by: Saswata Mukherjee <[email protected]>

* [ACM-16286]: Ensure hub and spoke obsaddon are synced based on spec

Signed-off-by: Saswata Mukherjee <[email protected]>

* [ACM-16286]: Allow customizing ObsAddon in spoke ns

Signed-off-by: Saswata Mukherjee <[email protected]>

* [ACM-16286]: Comments

Signed-off-by: Saswata Mukherjee <[email protected]>

* Add addon source annotation

Signed-off-by: Saswata Mukherjee <[email protected]>

* Add handling for empty map

Signed-off-by: Saswata Mukherjee <[email protected]>

* Add handling for nil maps

Signed-off-by: Saswata Mukherjee <[email protected]>

* Add annotation predicate, update in mco mode

Signed-off-by: Saswata Mukherjee <[email protected]>

* Fix unit test, make addon annotation constant

Signed-off-by: Saswata Mukherjee <[email protected]>

* Update comment

Signed-off-by: Saswata Mukherjee <[email protected]>

* Address comments

Signed-off-by: Saswata Mukherjee <[email protected]>

* Use semantic deepequal, add test for setter

Signed-off-by: Saswata Mukherjee <[email protected]>

* Set spoke addon correctly after comparison

Signed-off-by: Saswata Mukherjee <[email protected]>

---------

Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode saswatamcode changed the title [ACM-16286]: Ensure MCO spec addon options are propagated correctly (… [ACM-16286/backport 2.12]: Ensure MCO spec addon options are propagated correctly Dec 16, 2024
@coleenquadros
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [coleenquadros,saswatamcode]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saswatamcode
Copy link
Member Author

/retest

2 similar comments
@saswatamcode
Copy link
Member Author

/retest

@saswatamcode
Copy link
Member Author

/retest

Copy link

sonarcloud bot commented Dec 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
67.4% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

Copy link

openshift-ci bot commented Dec 17, 2024

@saswatamcode: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 7db60ca link false /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@saswatamcode saswatamcode merged commit 64a43b5 into stolostron:release-2.12 Dec 17, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants