Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update siteconfig deployment manifests #145

Conversation

sakhoury
Copy link

@sakhoury sakhoury commented Dec 4, 2024

No description provided.

Copy link

sonarqubecloud bot commented Dec 4, 2024

@@ -44,7 +44,7 @@ spec:
type: RuntimeDefault
containers:
- command:
- /usr/local/bin/manager
- /usr/local/bin/siteconfig-manager
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this work before 😕

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this in my last PR and missed updating here.

Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, sakhoury

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c503197 into stolostron:main Dec 5, 2024
15 checks passed
@sakhoury sakhoury deleted the update-deployment-related-manifests branch December 5, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants