Removes GA measurement API integration from banner (#265)

* Removes GA measreument API form banner * remove mention of tid in docs --------- Co-authored-by: Sarah Richards <[email protected]>
stormid · Sep 26, 2024 · 83e7890 · 83e7890
1 parent bded3b2
commit 83e7890
Show file tree

Hide file tree

Showing 25 changed files with 33 additions and 594 deletions.
diff --git a/docs/cookie-banner.html b/docs/cookie-banner.html
@@ -217,7 +217,6 @@ <h2 id="usage">Usage</h2>
 <pre><code>import banner from '@stormid/cookie-banner';
 
 const cookieBanner = banner({
-    tid: 'UA-XXXXXXXX-X',
     types: {
         'performance': {
             suggested: true, //set as pre-checked on consent form as a suggested response
@@ -255,7 +254,6 @@ <h2 id="usage">Usage</h2>
 <h2 id="options">Options</h2>
 <pre><code>{
     name: '.CookiePreferences', //name of the cookie set to record user consent
-    tid: '', // Google Analytics tracking id for Measurement API event tracking
     path: '/', //path of the preferences cookie
     domain: window.location.hostname === 'localhost' ? '' : `.${removeSubdomain(window.location.hostname)}`, //domain of the preferences cookie, defaults to .&lt;root-domain&gt;
     secure: true, //preferences cookie secure

diff --git a/packages/cookie-banner/README.md b/packages/cookie-banner/README.md
@@ -4,8 +4,6 @@ GDPR compliant cookie banner and consent form.
 
 Renders a cookie banner and a consent form based on configuration settings, and conditionally invokes cookie-reliant functionality based on user consent.
 
-Optionally send anonymous [predefined cookie banner and consent form interaction measurements](./measurements.md) to a specified Google Analytics using the Google Measurement API.
-
 ---
 
 ## Usage
@@ -38,7 +36,6 @@ Initialise the module (example configuration shown below)
 import banner from '@stormid/cookie-banner';
 
 const cookieBanner = banner({
-    tid: 'UA-XXXXXXXX-X',
     types: {
         'performance': {
             suggested: true, //set as pre-checked on consent form as a suggested response
@@ -78,7 +75,6 @@ const cookieBanner = banner({
 ```
 {
     name: '.CookiePreferences', //name of the cookie set to record user consent
-    tid: '', // Google Analytics tracking id for Measurement API event tracking
     path: '/', //path of the preferences cookie
     domain: window.location.hostname === 'localhost' ? '' : `.${removeSubdomain(window.location.hostname)}`, //domain of the preferences cookie, defaults to .<root-domain>
     secure: true, //preferences cookie secure

diff --git a/packages/cookie-banner/__tests__/banner/index.js b/packages/cookie-banner/__tests__/banner/index.js
@@ -7,7 +7,6 @@ const init = () => {
     cookieBanner({
         secure: false,
         hideBannerOnFormPage: false,
-        tid: 'UA-XXXXX-Y',
         types: {
             test: {
                 title: 'Test title',
@@ -51,7 +50,6 @@ describe(`Cookie banner > DOM > not render`, () => {
         cookieBanner({
             secure: false,
             hideBannerOnFormPage: true,
-            tid: 'UA-XXXXX-Y',
             types: {
                 test: {
                     title: 'Test title',

diff --git a/packages/cookie-banner/__tests__/banner/showBanner.js b/packages/cookie-banner/__tests__/banner/showBanner.js
@@ -8,7 +8,6 @@ const init = () => {
     document.body.innerHTML = `<main></main>`;
     instance = cookieBanner({
         secure: false,
-        tid: 'UA-XXXXX-Y',
         types: {
             test: {
                 title: 'Test title',

diff --git a/packages/cookie-banner/__tests__/consent.js b/packages/cookie-banner/__tests__/consent.js
@@ -29,7 +29,7 @@ describe(`Cookie banner > consent > callback`, () => {
             }
         };
 
-        const state = { settings: {tid: 'UA-XXXXX-Y', types}, consent: { test: 1, test2: 0 }};
+        const state = { settings: { types }, consent: { test: 1, test2: 0 }};
         applyEffects(state);
         expect(document.getElementById('test').textContent).toEqual("Consent given");
         expect(document.getElementById('test2').textContent).toEqual("");

diff --git a/packages/cookie-banner/__tests__/cookies.js b/packages/cookie-banner/__tests__/cookies.js
@@ -7,7 +7,6 @@ const init = () => {
     window.__cb__ = cookieBanner({
         secure: false,
         hideBannerOnFormPage: false,
-        tid: 'UA-141774857-1',
         types: {
             test: {
                 title: 'Test title',
@@ -41,15 +40,13 @@ describe(`Cookie banner > cookies > update`, () => {
 
     it('Sets a cookie based on preferences form', async () => {
         document.querySelector(`.${defaults.classNames.acceptBtn}`).click();
-        //get the cid from state
-        const cid = window.__cb__.getState().persistentMeasurementParams.cid;
-        expect(document.cookie).toEqual(`${defaults.name}=${btoa(`{"consent":{"test":1,"performance":1},"cid":"${cid}"}`)}`);
+        expect(document.cookie).toEqual(`${defaults.name}=${btoa(`{"consent":{"test":1,"performance":1}}`)}`);
 
         const fields = Array.from(document.querySelectorAll(`.${defaults.classNames.field}`));
         fields[1].checked = true;
         fields[3].checked = true;
         document.querySelector(`.${defaults.classNames.submitBtn}`).click();
-        expect(document.cookie).toEqual(`${defaults.name}=${btoa(`{"consent":{"test":0,"performance":0},"cid":"${cid}"}`)}`);
+        expect(document.cookie).toEqual(`${defaults.name}=${btoa(`{"consent":{"test":0,"performance":0}}`)}`);
     });
 
 });

diff --git a/packages/cookie-banner/__tests__/form/api.js b/packages/cookie-banner/__tests__/form/api.js
@@ -8,7 +8,6 @@ describe(`Cookie banner > DOM > form > render by api`, () => {
         const instance = cookieBanner({
             secure: false,
             hideBannerOnFormPage: false,
-            tid: 'UA-XXXXX-Y',
             types: {
                 test: {
                     suggested: true,

diff --git a/packages/cookie-banner/__tests__/form/interactions.js b/packages/cookie-banner/__tests__/form/interactions.js
@@ -13,7 +13,6 @@ describe(`Cookie banner > DOM > form interactions`, () => {
         window.__cb__ = cookieBanner({
             secure: false,
             hideBannerOnFormPage: false,
-            tid: 'UA-141774857-1',
             types: {
                 test: {
                     title: 'Test title',
@@ -59,9 +58,7 @@ describe(`Cookie banner > DOM > form interactions`, () => {
 
     it('Submit button should set the cookie and hide the banner', async () => {
         document.querySelector(`.${defaults.classNames.acceptBtn}`).click();
-        //get the cid from state
-        const cid = window.__cb__.getState().persistentMeasurementParams.cid;
-        expect(document.cookie).toEqual(`${defaults.name}=${btoa(`{"consent":{"test":1,"performance":1},"cid":"${cid}"}`)}`);
+        expect(document.cookie).toEqual(`${defaults.name}=${btoa(`{"consent":{"test":1,"performance":1}}`)}`);
         expect(document.querySelector(`.${defaults.classNames.banner}`)).toBeNull();
     });
 });
diff --git a/packages/cookie-banner/__tests__/form/not-render.js b/packages/cookie-banner/__tests__/form/not-render.js
@@ -4,7 +4,6 @@ import defaults from '../../src/lib/defaults';
 describe(`Cookie banner > DOM > form > not render`, () => {
     document.body.innerHTML = `<div></div>`;
     cookieBanner({
-        tid: 'UA-XXXXX-Y',
         types: {
             test: {
                 title: 'Test title',

diff --git a/packages/cookie-banner/__tests__/form/render.js b/packages/cookie-banner/__tests__/form/render.js
@@ -7,7 +7,6 @@ describe(`Cookie banner > DOM > form > render`, () => {
         cookieBanner({
             secure: false,
             hideBannerOnFormPage: false,
-            tid: 'UA-XXXXX-Y',
             types: {
                 test: {
                     suggested: true,

diff --git a/packages/cookie-banner/__tests__/measure/init.js b/packages/cookie-banner/__tests__/measure/init.js
diff --git a/packages/cookie-banner/__tests__/measure/measurements/accept-and-update.js b/packages/cookie-banner/__tests__/measure/measurements/accept-and-update.js
diff --git a/packages/cookie-banner/__tests__/measure/measurements/options.js b/packages/cookie-banner/__tests__/measure/measurements/options.js