remove auto height setting #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbp
reviewed
Oct 10, 2024
|
Aah of course that's what it's there to do. Cool - have updated to the fix in the original issue ticket which works perfectly well in both directions! |
|
Great, thanks! I'll release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #240
I was able to replicate this one in the examples, and the culprit seems to be setting the height of the text area to auto - causing the browser to jump.
I gave this a shot without setting the height to auto first, and it seemed to still work fine. I checked in Chrome, FF, Edge and safari iOS.
I can see that setting the height to auto first is recommended in the blog posts I've found about auto-resizing text areas. However those all seem to be a good few years old now, so perhaps more modern browsers no longer have that requirement in order to grab an accurate scroll height?
The original fix in the ticket also works though, so if it's better to go with that then I can update!