Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/241 cookie banner remove template #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/241 cookie banner remove template #269

wants to merge 2 commits into from

Conversation

sarah-storm
Copy link
Contributor

Closes #241

  • Banner and Form templates removed from config defaults
  • Documentation in Readme and HTML updated to reflect that providing these functions is now mandatory
  • Added a check before initialising the banner to make sure these are provided, and warns in the console if not found
  • Updates tests and examples so that they run with the new config requirements
  • Adds a new test to check that banner doesn't run if config is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjbp mjbp Awaiting requested review from mjbp

@catvine-stormid catvine-stormid Awaiting requested review from catvine-stormid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cookie banner > remove form and banner templates from defaults
1 participant
@sarah-storm