Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tests for the latest api version #23

Merged
merged 1 commit into from
Apr 29, 2024
Merged

update tests for the latest api version #23

merged 1 commit into from
Apr 29, 2024

Conversation

tyitang
Copy link
Collaborator

@tyitang tyitang commented Apr 29, 2024

Description

    1. Delete tests of deprecated endpoints
    1. Add tests for the new endpoints
    1. Comment out the sort test since orderBy is not supported in this version
    1. Update tests add null value and default order check
    1. Update the default testnet

AndyBoWu
AndyBoWu approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@AndyBoWu AndyBoWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick look, and it looks good.

Nice work @tyitang !!

@AndyBoWu AndyBoWu merged commit ae718de into main Apr 29, 2024
2 checks passed
@AndyBoWu AndyBoWu deleted the fix-sepolia-tests branch April 29, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyBoWu AndyBoWu AndyBoWu approved these changes

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyitang @AndyBoWu