Bump up sdk to v1.2.0-rc.0 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove collectRoyaltyTokens methods and Update getRoyaltyVaultAddress method * Update createNFTCollection params * Update contract addresses * Update unit and integration tests * Add mintAndRegisterIp method in ipAsset * Refactor validate license terms * Add registerPilTermsAndAttach method in ipAsset * Adjust related methods referencing address * Add todo hint * Add registerIpAndMakeDerivativeWithLicenseTokens method in IpAsset module * Add transferToVaultAndSnapshotAndClaimByTokenBatch method * Add royalty related workflow methods * Solve ERC721 error * Add group workflow relate methods * Update new contract address * Add debugger log * Add registerGroupAndAttachLicenseAndAddIps unit tests * Solve invalid signature and royalty error * Add the related methods unit tests * Add tests and enhance code * Remove license terms register check * Add integration tests in command * Update group pool description * Skip integration tests
bonnie57
requested review from
DonFungible,
edisonz0718,
jacob-tucker and
AndyBoWu
as code owners
allenchuang
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
We will need to update the license functions in https://linear.app/storyprotocol/issue/SDK-21/add-support-for-lrp-function-for-registercommercialusepil-and
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description