-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sam/provider api key #78
Open
samfairbairn
wants to merge
22
commits into
main
Choose a base branch
from
sam/provider-api-key
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samfairbairn
requested review from
LeoHChen,
allenchuang,
SoYoung210 and
DonFungible
as code owners
November 22, 2024 09:47
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SoYoung210
reviewed
Nov 22, 2024
@@ -7,7 +7,13 @@ export default function Providers({ children }: { children: React.ReactNode }) { | |||
const queryClient = new QueryClient() | |||
return ( | |||
<QueryClientProvider client={queryClient}> | |||
<StoryKitProvider chain={STORYKIT_SUPPORTED_CHAIN.STORY_TESTNET} theme="my-theme"> | |||
<StoryKitProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if StoryKitProvider
is appropriate for API environment
It seems like those env vars are only needed for IP-related API calls. How about... move to IpProvider
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this branch takes the api key, app id and simplehash api key passed into the
StoryKitProvider
and passes it to to all api & simplehash requests, eliminating need forNEXT_PUBLIC_STORY_PROTOCOL_X_API_KEY
andNEXT_PUBLIC_SIMPLE_HASH_API_KEY
env variableschanges include:
apiKey
,appId
,chainName
,apiVersion
arguments for api functionsgetResource
andlistResource
simplehashId
,simplehashKey
arguments for simplehash functionsfrom
to