Add support for starting stopping and refreshing pools #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
coverage task will fail. |
mulkieran
force-pushed
the
start-stop
branch
5 times, most recently
from
fc5d472 to
8cd6276
Compare
|
stratisd dependent tests should all fail. |
mulkieran
force-pushed
the
start-stop
branch
6 times, most recently
from
6de8048 to
3ac648c
Compare
|
rebased. |
mulkieran
requested review from
bmr-cymru,
bgurney-rh,
lleshchi,
jbaublitz and
drckeefe
and removed request for
bgurney-rh,
lleshchi and
jbaublitz
|
The bug in listing stopped pools should be fixed now. |
drckeefe
approved these changes
May 31, 2022
|
rebased. |
bmr-cymru
approved these changes
Jun 1, 2022
src/stratis_cli/_actions/_pool.py
Outdated
| """ | ||
| Get a cell value or N/A if None. | ||
| Take a value that represents possibly inconsistency via option type. |
|
This passes all tests again stratis-storage/stratisd#2949 . |
|
Should we allow |
|
All tests and coverage succeed when run against: stratis-storage/stratisd#2949 . |
mulkieran
changed the title
jbaublitz
approved these changes
Jun 21, 2022
Remove global unlock command and StratisCliAggregateError. Add a start and stop command on pools. Add a new global debug subcommand for refresh. Add additional options to the pool list command for showing stopped pools and detailed views on individual pools. Signed-off-by: mulhern <[email protected]>
|
rebased and squashed. All tests are expected to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #725
Related stratis-storage/project#296
Related #866