[SDFAB-844] Support static configuration of slices via netcfg #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion of queues to TCs (#453) * Add SlicingProviderService interface * Remove slice/tc initialization from FabricUpfProgrammable We wil use netcfg for initialization * Remove slice/tc initialization from FabricUpfProgrammable We wil use netcfg for initialization * Remove REST API for adding/removing slice/tcs * Remove unused CLI commands * Revisit TrafficClass and remove hardcoded initialization Sytem is not a traffic class * Introduce TrafficClassConfig class * Remove queue allocation logic * Comments and renaming on SlicingManager * Fix meter color int value * Less ambiguous handling of BE * Fix tests * Remove leftover QueueStoreValue * Javadoc * Wordsmithing * Improvements to TrafficClassConfig * Rename config class to description to disambiguate from netcfg * Use default for mobile slice * clean up rest API docs * address review comments * Fix test and checkstyles * Move distributed store destroy to preDeactivate hook * Update default tc javadoc * Fix tests
* Add SlicingProviderService interface * Remove slice/tc initialization from FabricUpfProgrammable We wil use netcfg for initialization * Remove slice/tc initialization from FabricUpfProgrammable We wil use netcfg for initialization * Remove REST API for adding/removing slice/tcs * Remove unused CLI commands * Revisit TrafficClass and remove hardcoded initialization Sytem is not a traffic class * Introduce TrafficClassConfig class * Remove queue allocation logic * Comments and renaming on SlicingManager * Fix meter color int value * Less ambiguous handling of BE * Fix tests * Remove leftover QueueStoreValue * Javadoc * Wordsmithing * Improvements to TrafficClassConfig * Rename config class to description to disambiguate from netcfg * First stab at config class * First stab at tests for SlicingTests * Forgot to check in the test JSON * Consistently call it tcDescription instead of tcConfig * Remove ability to configure best effort queue ID For now, we can safely assume it will always be 0 * Use default for mobile slice * clean up rest API docs * address review comments * Fix test and checkstyles * Move distributed store destroy to preDeactivate hook * Update default tc javadoc * javadoc * review comments * tests * Fix tests * Restore double quotes in json example
* Add SlicingProviderService interface * Remove slice/tc initialization from FabricUpfProgrammable We wil use netcfg for initialization * Remove slice/tc initialization from FabricUpfProgrammable We wil use netcfg for initialization * Remove REST API for adding/removing slice/tcs * Remove unused CLI commands * Revisit TrafficClass and remove hardcoded initialization Sytem is not a traffic class * Introduce TrafficClassConfig class * Remove queue allocation logic * Comments and renaming on SlicingManager * Fix meter color int value * Less ambiguous handling of BE * Fix tests * Remove leftover QueueStoreValue * Javadoc * Wordsmithing * Improvements to TrafficClassConfig * Rename config class to description to disambiguate from netcfg * First stab at config class * First stab at tests for SlicingTests * Forgot to check in the test JSON * Consistently call it tcDescription instead of tcConfig * Move constants to root package * Centralize app name constants in one place It was hard to kkep track of the different app names used * Progress on netcfg slicing provider * Working config add/remove * Fix copyright * Read initial config * wordsmithing * Dyanmic config of system tc * Remove ability to configure best effort queue ID For now, we can safely assume it will always be 0 * Clean up * Use default for mobile slice * clean up rest API docs * address review comments * Fix test and checkstyles * Doubt * Move distributed store destroy to preDeactivate hook * Update default tc javadoc * javadoc * review comments * tests * Fix tests * Address review comments * Add initial tests * Add additional tests * Address review comments * Add tests for system tc handling * Re-add double quotes to javadoc config example * Address Charles's comment
Codecov Report
@@ Coverage Diff @@
## main #462 +/- ##
============================================
+ Coverage 67.74% 69.28% +1.53%
- Complexity 645 694 +49
============================================
Files 63 59 -4
Lines 4545 4616 +71
Branches 490 514 +24
============================================
+ Hits 3079 3198 +119
+ Misses 1222 1157 -65
- Partials 244 261 +17
Continue to review full report at Codecov.
|
daniele-moro
approved these changes
Jan 25, 2022
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
SlicingManagerto:maxRateBps,gminRateBps, etc.This PR combines changes from the following already-reviewed intermediate PRs: