Refactored how firecore tools handles printing
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is now a common flag for all `tools` subcommand `output` that can be one of: text, json, jsonl, protojson or protojsonl. Commands that had flags defined have been removed, this should be backward compatible. The text printer is now more clever and is able to print details about most blocks.
maoueh
commented
Dec 9, 2024
| if err != nil { | ||
| fmt.Printf("❌ Unable to print block %s: %s\n", block.AsRef(), err) | ||
| continue | ||
| } | ||
| } | ||
|
|
||
| if printDetails == PrintFull { | ||
| printer, err := print2.GetOutputPrinter(globalToolsCheckCmd, chain.BlockFileDescriptor()) |
There was a problem hiding this comment.
I plan to remove all printing support from check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is now a common flag for all
toolssubcommandoutputthat can be one of: text, json, jsonl, protojson or protojsonl.Commands that had flags defined have been removed, this should be backward compatible.
The text printer is now more clever and is able to print details about most blocks.