Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: at note about browser refresh behaviour #728

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

janaka
Copy link

@janaka janaka commented Jul 3, 2023

Add note in the caveat section about state resetting when browser refreshed.

📚 Context

This is a key behaviour that isn't expected given how other frameworks work and how session is generally understood. Arguably this point should be highlighted in a more prominent way. Also relates to PR #676.

🧠 Description of Changes

Added a new bullet under the caveats section at the top.

No existing content has been modified or deleted.

Revised:

note: screenshot of GH render of MD but should be sufficient for this change.
image

Current:

image

💥 Impact

Size:

  • Small
  • Not small

🌐 References

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

Add note in the caveat section about state resetting when browser refreshed.
@janaka janaka marked this pull request as ready for review July 3, 2023 10:22
@snehankekre snehankekre self-requested a review August 23, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant