Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ZooKeeper-based cluster fields in the API #10979

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Dec 20, 2024

Type of change

  • Task

Description

This PR deprecates the API fields related to ZooKeeper-based clusters:

  • Deprecated .spec.zookeeper section
  • Deprecated .spec.kafka.replicas section
  • Deprecated .spec.kafka.storage section
  • Unused ZooKeeper-related methods from KafkaResources were removed
  • The tests related to the Kafka CR were cleaned up to focus on Kraft-based clusters and maintain just one legacy ZooKeeper-based Kafka CR YAML to make sure we still support it in the CRDs
  • As we now have the automatic deprecation warnings, the warnings generated from KRaftUtils were removed as they are not needed anymore
  • In System Tests, some of these deprecated fields are still used and this will be cleaned only when ZooKeeper is cleaned-up from the STs. So for the time being, the deprecation warnings are suppressed
  • The replicas are also still used in the KafkaClusterCreator -> this piece was missed in Remove ZooKeeper support - Part I #10964. As this will likely have a larger refactoring, for the time being I just suppressed the deprecation warning and will address it in a follow-up PR.
  • The generated CRD reference in the docs has been updated, but the docs themself will be updated only in one of the follow up PRs.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

@scholzj scholzj added this to the 0.46.0 milestone Dec 20, 2024
@scholzj scholzj requested a review from ppatierno December 20, 2024 20:57
@scholzj
Copy link
Member Author

scholzj commented Dec 20, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Dec 20, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Dec 21, 2024

/azp run feature-gates-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Dec 21, 2024

(The OPA STs failure is not related to this PR but to #10980)

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scholzj scholzj merged commit bfd30db into strimzi:main Dec 23, 2024
29 of 33 checks passed
@scholzj scholzj deleted the deprecate-zookeeper-from-apis branch December 23, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants