[CONSUMERBANK-528] Handle invalid phone numbers in Link signup more gracefully #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mats-stripe
commented
Nov 15, 2024
|
|
||
| // Hack to determine if the error is related to the phone number. | ||
| // If so, show a generic error message under the phone textfield. | ||
| if let errorMessage = stripeAPIError.message, errorMessage.contains("phone") { |
There was a problem hiding this comment.
I wasn't sure if I should search for the localized string "phone" here, or hardcode the english word. Are remote error messages localized?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the Link Login pane to more gracefully handle errors related to the phone number. Previously, we had very little input validation on the phone textfield, and any API errors related to an improperly formatted phone number would lead to the terminal error pane. This attempts to catch phone number related API errors, and present them under the phone textfield.
Motivation
CONSUMERBANK-528
Testing
Screen.Recording.2024-11-14.at.2.51.05.PM.mov
Changelog
N/a