Skip to content

Commit

Permalink
updated linting
Browse files Browse the repository at this point in the history
  • Loading branch information
patrick-hermann-sva committed Nov 17, 2024
1 parent bd703a6 commit 41a7ffd
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 30 deletions.
54 changes: 27 additions & 27 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,33 +100,33 @@ linters:
- errcheck
- errorlint
- funlen
- gocheckcompilerdirectives
- gochecknoinits
- goconst
- gocritic
- gocyclo
- godox
- gofmt
- goimports
- mnd
- goprintffuncname
- gosec
- gosimple
- govet
- ineffassign
- lll
- misspell
- nakedret
- noctx
- nolintlint
- revive
- staticcheck
- stylecheck
- testifylint
- unconvert
- unparam
- unused
- whitespace
# - gocheckcompilerdirectives
# - gochecknoinits
# - goconst
# - gocritic
# - gocyclo
# - godox
# - gofmt
# - goimports
# - mnd
# - goprintffuncname
# - gosec
# - gosimple
# - govet
# - ineffassign
# - lll
# - misspell
# - nakedret
# - noctx
# - nolintlint
# - revive
# - staticcheck
# - stylecheck
# - testifylint
# - unconvert
# - unparam
# - unused
# - whitespace

# This list of linters is not a recommendation (same thing for all this configuration file).
# We intentionally use a limited set of linters.
Expand Down
5 changes: 4 additions & 1 deletion cmd/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,10 @@ var createCmd = &cobra.Command{
fmt.Println(gitTree)

// PUSH COMMIT
sthingsCli.PushCommit(client, ref, gitTree, groupName, repositoryName, authorName, authorEmail, commitMessage)
err = sthingsCli.PushCommit(client, ref, gitTree, groupName, repositoryName, authorName, authorEmail, commitMessage)
if err != nil {
log.Fatalf("UNABLE TO PUSH THE COMMIT: %s\n", err)
}

case "pr":
log.Info("CREATING PULL REQUEST")
Expand Down
5 changes: 4 additions & 1 deletion internal/git.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,10 @@ func GitCommitFile(repository string, auth *http.BasicAuth, fileContent []byte,
fmt.Println(w.Status())

// git commit -m $message
w.Commit(commitMsg, &git.CommitOptions{})
_, commited := w.Commit(commitMsg, &git.CommitOptions{})
if commited != nil {
return fmt.Errorf("could not git commit: %w", commited)
}

//Push the code to the remote
err = r.Push(&git.PushOptions{
Expand Down
5 changes: 4 additions & 1 deletion surveys/profiles.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,10 @@ func SelectReleaseProfiles(yamlFile string) (selectedReleaseProfiles []string, a

}

pterm.DefaultTable.WithHasHeader().WithBoxed().WithData(repositoryTable).Render()
rendered := pterm.DefaultTable.WithHasHeader().WithBoxed().WithData(repositoryTable).Render()
if err := rendered; err != nil {
log.Error(err)
}

selectedReleaseProfiles = sthingsCli.AskMultiSelectQuestion("SELECT TO RELEASE:", allKeys)

Expand Down

0 comments on commit 41a7ffd

Please sign in to comment.