Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Stylelint v16 #540

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
+324 −833
Draft

feat: support Stylelint v16 #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
71b511d
ci: test Stylelint v16
ybiquitous Mar 22, 2024
eeb307e
Fix type and lint errors
ybiquitous Mar 22, 2024
cd5b368
Use `@ts-ignore` instead of `@ts-expect-error` for older Stylelint ve…
ybiquitous Mar 22, 2024
9cf6812
Fix unit test failures caused by removed rule in Stylelint v16
ybiquitous Mar 22, 2024
0c68297
Avoid using deprecated `LinterResult.output` property
ybiquitous Mar 22, 2024
0d5d51d
Check existence of `LinterResult.report` property
ybiquitous Mar 22, 2024
d576a3c
Decrease branch coverage's threshold a bit
ybiquitous Mar 22, 2024
e4b1620
Improve job name wording
ybiquitous Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
stylelint: [14, 15]
stylelint: ['14', '15', '16']
timeout-minutes: 30
permissions:
contents: read
Expand All @@ -38,13 +38,17 @@ jobs:
- name: Install dependencies
run: npm ci

- name: Install stylelint v15
run: npm i -D stylelint@^15
if: matrix.stylelint == 15
- name: Install Stylelint 16
run: npm i -D stylelint@16 stylelint-scss@6
if: ${{ matrix.stylelint == '16' }}

- name: Install stylelint v14
run: npm i -D stylelint@^14 stylelint-scss@^4.3.0
if: matrix.stylelint == 14
- name: Install Stylelint 15
run: npm i -D stylelint@15 stylelint-scss@5
if: ${{ matrix.stylelint == '15' }}

- name: Install Stylelint 14
run: npm i -D stylelint@14 [email protected]
if: ${{ matrix.stylelint == '14' }}

- name: Cache VS Code binaries
uses: actions/cache@v4
Expand All @@ -65,9 +69,9 @@ jobs:
run: npm run test:integration -- --coverage

- name: Run end-to-end tests (Linux)
if: runner.os == 'Linux'
if: ${{ runner.os == 'Linux' }}
run: xvfb-run -a npm run test:e2e -- --silent

- name: Run end-to-end tests (non-Linux)
if: runner.os != 'Linux'
if: ${{ runner.os != 'Linux' }}
run: npm run test:e2e -- --silent
Loading
Loading