Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.4.0 #541

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Prepare 1.4.0 #541

merged 1 commit into from
Mar 28, 2024

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

None.

Is there anything in the PR that needs further explanation?

Ref v1.3.0...main

Note: I have never performed releasing this extension yet, so feel free to comment if there are any mistakes. 🙏🏼

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ybiquitous
Copy link
Member Author

@ota-meshi I will release the version after merging this PR, but I've never done it. So, let me ask a few questions:

  • Is there any rule for publishing this extension?
  • Does releasing require any manual work? (e.g. work in a terminal)
  • Is any permission necessary?
  • Is there any automation like this?

@ota-meshi
Copy link
Member

Is there any rule for publishing this extension?

I don't think there are any rules.

Does releasing require any manual work? (e.g. work in a terminal)

Currently, manual work is required. I always do the publish manually using the terminal.

Is any permission necessary?

I think you need to get a PAT to publish VSCode. Perhaps the PAT we previously obtained has expired and we need a new one.

https://code.visualstudio.com/api/working-with-extensions/publishing-extension

Is there any automation like this?

I haven't automated it. Until now, we haven't released this extension often so I haven't really needed it 😅

@ybiquitous
Copy link
Member Author

Thank you for the answer! 👍🏼

Copy link
Member

@adalinesimonian adalinesimonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing all this. :)

@ybiquitous
Copy link
Member Author

Thank you guys. I'll try the release tonight 😃

@ybiquitous
Copy link
Member Author

I'm starting the release now... 🚀

@ybiquitous ybiquitous merged commit 0f9e454 into main Mar 28, 2024
7 checks passed
@ybiquitous ybiquitous deleted the prepare-next-version branch March 28, 2024 13:42
ybiquitous added a commit that referenced this pull request Mar 28, 2024
Follow-up to PR #541
@ybiquitous
Copy link
Member Author

ybiquitous commented Mar 28, 2024

Checklist to release

Ref https://code.visualstudio.com/api/working-with-extensions/publishing-extension

@ybiquitous
Copy link
Member Author

Releasing is done! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants