Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate jest-runner-vscode to @vscode/test-cli #580

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Aug 26, 2024

Which issue, if any, is this issue related to?

Related to #504

Is there anything in the PR that needs further explanation?

jest-runner-vscode has been inactive for a long time, while @vscode/test-cli is officially maintained by the VS Code team.
See also https://code.visualstudio.com/api/working-with-extensions/testing-extension

Additionally, Mocha.js's BDD style, which is the basis of @vscode/test-cli, is similar to Jest, so I believe the learning cost is low.

@ybiquitous ybiquitous force-pushed the migrate-jest-runner-vscode-to-vscode-test-cli branch from c0bc000 to bfbf8c8 Compare August 26, 2024 14:44
@ybiquitous ybiquitous changed the title Migrate jest-runner-vscode to @vscode/test-cli test: migrate jest-runner-vscode to @vscode/test-cli Aug 26, 2024
@ybiquitous ybiquitous marked this pull request as ready for review August 26, 2024 16:22
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@ybiquitous ybiquitous merged commit 31162d1 into stylelint:main Aug 27, 2024
9 checks passed
@ybiquitous ybiquitous deleted the migrate-jest-runner-vscode-to-vscode-test-cli branch August 27, 2024 02:28
@ybiquitous ybiquitous added the pr: dependencies relates to dependencies label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: dependencies relates to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants